[sr-dev] Outbound support in registrar - SIPit 30

[Olle E. Johansson]

20 feb 2013 kl. 17:14 skrev Peter Dunkley <peter.dunkley at crocodile-rcs.com>:

> Hi Olle,
> 
> I've just looked at the code in git master.  In registrar/reply.c:reg_send_reply() there is this code:
> 
> 	switch (rerrno) {
> 	case R_FINE:
> 		...
> 		switch(reg_outbound_mode)
> 		{
> 		case REG_OUTBOUND_NONE:
> 		default:
> 			break;
> 
> 		case REG_OUTBOUND_REQUIRE:
> 			if (add_require(_m, &outbound_str) < 0)
> 				return -1;
> 
> 			if (reg_flow_timer > 0) {
> 				if (add_flow_timer(_m) < 0)
> 					return -1;
> 			}
> 			/* Fall-thru */
> 		case REG_OUTBOUND_SUPPORTED:
> 			if (add_supported(_m, &outbound_str) < 0)
> 				return -1;
> 				break;
> 		}
> 	...
> 
> This code means that when outbound_mode is 2 you should get a Require: and a Supported: header in the 200 OK containing the outbound options tag.
> 
> I added this over Christmas and remember testing this at the time - so I am not sure why you are not seeing the headers in your responses.
Yes, that seems weird. Will make a more focused test with that client and see what's going on.

/O
> 
> Regards,
> 
> Peter
> 
> 
> On 20/02/13 15:37, Olle E. Johansson wrote:
>> http://www.kamailio.org/wiki/devel/completing_outbound?&#work_required_to_complete_registrar_support
>> 
>> I am running in outbound_mode 2 in the registrar, since I have a mixed set of clients.
>> 
>> Clients that DO support outbound doesn't get a Require: header back in the response.
>> 
>> "If outbound registration succeeded, as indicated by the presence of
>>    the outbound option-tag in the Require header field of a successful
>>    registration response, the UA begins sending keep-alives as described
>>    in Section 4.4."
>> 
>> RFC 5626.
>> 
>> This client changed the source code faster than I could, but I still consider it a bug in our registrar mode 2.
>> 
>> /O
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev