[sr-dev] Memory leak in MSRP

[Daniel-Constantin Mierla]

On 2/12/13 5:46 PM, Peter Dunkley wrote:
> OK.
>
> I am working in this area now.  Should I just remove this unused 
> function to avoid future confusion?
I would keep it, does not harm at all -- the msrp parser is quite 
independent, should be easy to pull it to use for other needs.

The sip parser has kind of similar api, with a compile option to use a 
stack sip_msg_t variable or allocate dynamically. It makes no sense to 
do same for msrp handling, though.

Cheers,
Daniel

>
> Thanks,
>
> Peter
>
> On 12/02/13 15:19, Daniel-Constantin Mierla wrote:
>> Hello,
>>
>> msrp_free_frame() is not needed because the msrp_frame_t variable 
>> used for parsing the runtime msrp messages is declared static in 
>> msrp_mod.c (inside msrp_frame_received(...), which then needs to call 
>> only the msrp_destroy_frame()).
>>
>> The free function was added when developing the msrp parsing api, but 
>> is not necessary in the current code.
>>
>> Cheers,
>> Daniel
>>
>> On 2/12/13 4:06 PM, Peter Dunkley wrote:
>>> Hello,
>>>
>>> There is an msrp_free_frame() function, which in turn calls 
>>> msrp_destroy_frame().  These functions free up package memory 
>>> allocated for MSRP frames.  However, I can't find where 
>>> msrp_free_frame() is called.
>>>
>>> Should msrp_free_frame() be called, and if so where?
>>>
>>> Regards,
>>>
>>> Peter
>>>
>>> _______________________________________________
>>> sr-dev mailing list
>>> sr-dev at lists.sip-router.org
>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>>
>
>
> _______________________________________________
> sr-dev mailing list
> sr-dev at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, April 16-17, 2013, Berlin
  - http://conference.kamailio.com -