[sr-dev] Memory leak in MSRP
miconda at gmail.com
Tue Feb 12 18:33:52 CET 2013
On 2/12/13 5:46 PM, Peter Dunkley wrote:
> I am working in this area now. Should I just remove this unused
> function to avoid future confusion?
I would keep it, does not harm at all -- the msrp parser is quite
independent, should be easy to pull it to use for other needs.
The sip parser has kind of similar api, with a compile option to use a
stack sip_msg_t variable or allocate dynamically. It makes no sense to
do same for msrp handling, though.
> On 12/02/13 15:19, Daniel-Constantin Mierla wrote:
>> msrp_free_frame() is not needed because the msrp_frame_t variable
>> used for parsing the runtime msrp messages is declared static in
>> msrp_mod.c (inside msrp_frame_received(...), which then needs to call
>> only the msrp_destroy_frame()).
>> The free function was added when developing the msrp parsing api, but
>> is not necessary in the current code.
>> On 2/12/13 4:06 PM, Peter Dunkley wrote:
>>> There is an msrp_free_frame() function, which in turn calls
>>> msrp_destroy_frame(). These functions free up package memory
>>> allocated for MSRP frames. However, I can't find where
>>> msrp_free_frame() is called.
>>> Should msrp_free_frame() be called, and if so where?
>>> sr-dev mailing list
>>> sr-dev at lists.sip-router.org
> sr-dev mailing list
> sr-dev at lists.sip-router.org
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio World Conference, April 16-17, 2013, Berlin
- http://conference.kamailio.com -
More information about the sr-dev