[sr-dev] Memory leak in MSRP

[Peter Dunkley]

OK.

I am working in this area now.  Should I just remove this unused 
function to avoid future confusion?

Thanks,

Peter

On 12/02/13 15:19, Daniel-Constantin Mierla wrote:
> Hello,
>
> msrp_free_frame() is not needed because the msrp_frame_t variable used 
> for parsing the runtime msrp messages is declared static in msrp_mod.c 
> (inside msrp_frame_received(...), which then needs to call only the 
> msrp_destroy_frame()).
>
> The free function was added when developing the msrp parsing api, but 
> is not necessary in the current code.
>
> Cheers,
> Daniel
>
> On 2/12/13 4:06 PM, Peter Dunkley wrote:
>> Hello,
>>
>> There is an msrp_free_frame() function, which in turn calls 
>> msrp_destroy_frame().  These functions free up package memory 
>> allocated for MSRP frames.  However, I can't find where 
>> msrp_free_frame() is called.
>>
>> Should msrp_free_frame() be called, and if so where?
>>
>> Regards,
>>
>> Peter
>>
>> _______________________________________________
>> sr-dev mailing list
>> sr-dev at lists.sip-router.org
>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
>