[sr-dev] git:master: parser/digest: Fix hunting for Auth header in rare cases

Richard Fuchs rfuchs at sipwise.com
Mon Dec 17 16:21:37 CET 2012


On 12/17/12 08:47, Alex Hermann wrote:
> On Sunday 16 December 2012, Richard Fuchs wrote:
> 
>> +			ptr = ptr->next;
>> +			while (ptr) {
>> +				if (ptr->type == hftype)
>> +					break;
>> +				ptr = ptr->next;
>> +			}
>> +			if (!ptr)
>> +				break;
> 
> 
> There is a dedicated function for walking the sibling headers: 
> next_sibling_hdr(). Please consider using it instead of open coding the 
> loop. Like in attached patch i should have pushed log time ago ;)

Thanks for the hint. I was looking for a function that does this
(couldn't have been the first time someone needed to do that, right?)
but couldn't find it. I'll update the code.

cheers

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20121217/c1ba683b/attachment.pgp>


More information about the sr-dev mailing list