[sr-dev] git:master: parser/digest: Fix hunting for Auth header in rare cases

Alex Hermann alex at speakup.nl
Mon Dec 17 14:47:03 CET 2012


On Sunday 16 December 2012, Richard Fuchs wrote:

> +			ptr = ptr->next;
> +			while (ptr) {
> +				if (ptr->type == hftype)
> +					break;
> +				ptr = ptr->next;
> +			}
> +			if (!ptr)
> +				break;


There is a dedicated function for walking the sibling headers: 
next_sibling_hdr(). Please consider using it instead of open coding the 
loop. Like in attached patch i should have pushed log time ago ;)


-- 
Alex Hermann

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-parser-digest-check-for-sibling-Authorization-header.patch
Type: text/x-patch
Size: 1043 bytes
Desc: not available
URL: <http://lists.sip-router.org/pipermail/sr-dev/attachments/20121217/c32aaac3/attachment.bin>


More information about the sr-dev mailing list