[sr-dev] modules_k/dialog: no referencing to current dialog possible when using dlg_manage()

Daniel-Constantin Mierla miconda at gmail.com
Fri Mar 4 21:21:01 CET 2011


Hello,

On 3/4/11 4:42 PM, Timo Reimann wrote:
> [...]
>
> So how do we fix this?
>
> My idea is to simply remove the not-NULL-check against the transaction t
> prior to callback registration. If the transaction doesn't exists, the
> tm module makes sure that it will be created lazily. This is how the
> first callback registration for types TMCB_RESPONSE_READY and
> TMCB_RESPONSE_FWDED in dlg_create_dialog() already works, apparently
> with no issues. I also did a quick, simple test with the check left out
> that proved to work fine.
>
> As this looks like a fix to a work-around, however, I'd like to ask for
> some feedback first.
go ahead and commit it on master. I will look over it as well and then 
we can backport.

Thanks,
Daniel

-- 
Daniel-Constantin Mierla
http://www.asipto.com




More information about the sr-dev mailing list