[sr-dev] git:master: tm: support for changing the reply status in the script

[Miklos Tirpak]

On 05/27/2010 11:20 AM, Andrei Pelinescu-Onciul wrote:
> On May 27, 2010 at 09:29, Miklos Tirpak <miklos at iptel.org> wrote:
>> Hi,
>>
>> On 05/26/2010 11:46 PM, Iñaki Baz Castillo wrote:
>>> 2010/5/26 Miklos Tirpak <miklos at iptel.org>:
>>>>> How can the reply status be changed?
>>>> there should be some other function added, what tm module does is only
>>>> checking for the change. If you need it then I can add the function to
>>>> modules_s/textops for instance.
>>> Exotic question: what would occur if I change a 180 response to 486 in
>>> onreply_route? Transaction client must end in this case, would it
>>> happen?
>> to keep the feature simple, I disallowed this case. 1xx can be
>> changed only to 1xx, 2xx to 2xx, and [3456]xx to [3456]xx.
>>
>> As far as I know Andrei added support for sending replies from
>> onreply_route. You can call t_reply(486, "...") when the 180 is
>> received if you wish, I think tm will cancel the pending branch
>> properly. Hence, I did not care about this case, and just disallowed
>> it.
> 
> Yes, one can t_reply() the transaction from the on_reply route. Note though
> that this will act as the final reply (the transaction will be
> terminated, no failure route will be called) and not as a per branch
> reply.
> If you want to change the per-branch reply, you need to use Miklos's
> new addition with the limitation that you can't change the reply class.

Actually you can change the class when it is >=300, the new value should 
be also >=300. In other words, provisional, negative, and positive final 
replies cannot be swapped.

Miklos

> 
> 
> Andrei