[sr-dev] git:master: param_parser: Accept parameters with missing bodies.

[Jan Janak]

On Tue, Mar 2, 2010 at 3:20 PM, Daniel-Constantin Mierla
<miconda at gmail.com> wrote:
>
>
> On 03/02/2010 08:47 PM, Jan Janak wrote:
>>
>> Module: sip-router
>> Branch: master
>> Commit: a3b2fcde99ebd5f625d0168473caef5dbbaf1029
>> URL:
>>  http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=a3b2fcde99ebd5f625d0168473caef5dbbaf1029
>>
>> Author: Jan Janak<jan at ryngle.com>
>> Committer: Jan Janak<jan at ryngle.com>
>> Date:   Tue Feb 23 14:38:31 2010 -0500
>>
>> param_parser: Accept parameters with missing bodies.
>>
>> This change makes the parameter parser more forgiving. It accepts
>> parameters with missing bodies (foo=), such parameters will have
>> the body set to an empty string. Observed on iptel.org
>>
>
> is this better than setting the pointer after '=' and the len 0?
>
> I haven't checked the code to see if it is the case, the only thing that
> could cause problems is cloning params structure to shm and doing pointer
> translations relative to original buffer.

You're right, I just checked the code and it could be a problem with
record-route parameters, because there the pointers get translated.

I'll fix it, thanks for pointing this out!

-Jan