[sr-dev] more fixups in mod_fix.h or what?

Andrei Pelinescu-Onciul andrei at iptel.org
Wed Apr 14 08:07:45 CEST 2010


On Apr 07, 2010 at 20:10, Juha Heinanen <jh at tutpro.com> wrote:
> Daniel-Constantin Mierla writes:
> 
>  > mod_fix.h should be used if there are more than one module using that 
>  > fixup, otherwise makes no sense, the fixup should stay in the module.
>  > 
>  > Using type of parameter in name of function does not scale anymore, so a 
>  > different name pattern should be chosen. Can be developer choice, 
>  > preferably suggestive if possible.
> 
> how about a new scheme, where in exports module writer lists the
> fixups in an arg string, for example,
> 
> {"test", (cmd_function)test, "pvar,str,spve", REQUEST_ROUTE |
> FAILURE_ROUTE},
> 
> names in the arg string can be well known (in which case nothing else
> needs to be done by module writer) or custom (in which case the
> corresponding fixup needs to be written by module writer).

In master it will soon be possible to have variables automatically
supported for functions with no fixups. However the args must not be in
quotes (no automatic fixup takes place for quoted strings).
E.g. foo($a, "test " + $b + "\n")  will work (the code is already in
the andrei/rve_f_params branch).


Andrei



More information about the sr-dev mailing list