[sr-dev] rfc: t_drop_replies()

Andrei Pelinescu-Onciul andrei at iptel.org
Wed Dec 2 20:41:26 CET 2009


On Dec 02, 2009 at 19:17, Daniel-Constantin Mierla <miconda at gmail.com> wrote:
> Hello,
> 
> based on the discussion from last weeks on sr-dev related to selection 
> of reply code for failure route, I did some updates in kamailio_3.0 
> branch. Main goal was to have the option of Kamailio 1.5 compatibility 
> mode. Here is the patch:
> 
> http://git.sip-router.org/cgi-bin/gitweb.cgi/sip-router/?a=commit;h=3ed668500c9a0f0d2f864f5a56cf7fa886f8457c
> 
> Description of the changes is included in the commit message.
> 
> Andrei, can you double check if there is any possible side effect 
> considering the new TM architecture inherited from ser? Patch is not that 
> complex.

It looks ok to me. The only minor problem is that the test for
TM_UAC_FLAG_FB should be done only #ifdef TM_UAC_FLAGS
(if TM_UAC_FLAGS is not defined one won't be able to do
t_drop_replies("last") because the "first" branch is no longer marked).


Andrei



More information about the sr-dev mailing list