[Kamailio-Devel] SF.net SVN: openser:[5284] trunk/modules/avpops/avpops_impl.c

[Daniel-Constantin Mierla]

On 02/09/2009 09:14 AM, Alex Hermann wrote:
> On Saturday 07 February 2009, Daniel-Constantin Mierla wrote:
>   
>> I will revert back that change if
>> it breaks, there was no other report, probably it is about how each is
>> checking the return code.
>>     
>
> It could very well be that the breakage is subtle enough to not notice it 
> until you start sending out bills and realize your rating queries had gone 
> berserk.
>   
Unfortunately it happens that a fix for something is a regression for 
other side.

>
>   
>> So leave you scripts untouched few days and should work just fine when
>> you will do the upgrade. Probably is wise to do negative return code to
>> select between those cases. Would be ok for you to differentiate error
>> case and no result by a negative reply code? As I could see, your
>> if(avp_db_...) won't break in that case.
>>     
>
> For the stable releases I think that would be a better solution.
>   
Right.

> I don't know which is the best option in the end. You're right when stating 
> that an empty result set isn't an error, so it should not return a negative 
> value. For an easier upgrade path however, a negative result would be 
>   

Will see in the future. Integration within sip-router should have in 
mind a better reply code policy.

Thanks for your assistance,
Daniel

> preferable. I really don't have a specific preference for what ends up in 
> 1.5, my main gripe was about changing the API in the stable releases.
>
>
> Greetings,
> Alex Hermann
>
> _______________________________________________
> Kamailio (OpenSER) - Devel mailing list
> Devel at lists.kamailio.org
> http://lists.kamailio.org/cgi-bin/mailman/listinfo/devel
> http://lists.openser-project.org/cgi-bin/mailman/listinfo/devel
>
>   

-- 
Daniel-Constantin Mierla
http://www.asipto.com