[Kamailio-Devel] SF.net SVN: openser:[5284] trunk/modules/avpops/avpops_impl.c

[Alex Hermann]

On Saturday 07 February 2009, Daniel-Constantin Mierla wrote:
> I will revert back that change if
> it breaks, there was no other report, probably it is about how each is
> checking the return code.

It could very well be that the breakage is subtle enough to not notice it 
until you start sending out bills and realize your rating queries had gone 
berserk.


> So leave you scripts untouched few days and should work just fine when
> you will do the upgrade. Probably is wise to do negative return code to
> select between those cases. Would be ok for you to differentiate error
> case and no result by a negative reply code? As I could see, your
> if(avp_db_...) won't break in that case.

For the stable releases I think that would be a better solution.

I don't know which is the best option in the end. You're right when stating 
that an empty result set isn't an error, so it should not return a negative 
value. For an easier upgrade path however, a negative result would be 
preferable. I really don't have a specific preference for what ends up in 
1.5, my main gripe was about changing the API in the stable releases.


Greetings,
Alex Hermann