[Kamailio-Devel] RFC: Dialog: Feature-Extensions

[Ovidiu Sas]

Hello Carsten,

For the first two items, please use two commits (one for each
individual item) so it will be easier to track changes.
For the last item, please open a new thread and lets discuss it there.
If you have a working patch, please upload it to the tracker so other
can test it and provide feedback.


Regards,
Ovidiu Sas

On Tue, Sep 16, 2008 at 12:04 PM, Carsten Bock <lists at bock.info> wrote:
> Hi,
>
> Am Dienstag, den 16.09.2008, 18:18 +0300 schrieb Daniel-Constantin
> Mierla:
>> Hello Carsten,
>>
>>
>> On 09/16/08 17:58, Carsten Bock wrote:
>> > Hi,
>> >
>> > I have some extensions for the dialog module (currently for the
>> > 1.3-release, but i could also port it easily to SVN-Trunk):
>> > - in case "tight matching" fails (when using the Record-Route-Parameter
>> > for in-dialog requests), try to find the dialog based on the
>> > SIP-Elements in the message
>> >
>>
>> isn't this already integrated, or I misunderstood?
>>
>> http://www.kamailio.org/docs/modules/1.4.x/dialog.html#id2467954
>>
>
> the current state is, that it checks for the existence of the cookie. If
> no cookie present, it will try perform a lookup based on
> SIP-credentials. The change will also perform the lookup, if the cookie
> is present but contains invalid information (e.g. points either to no
> dialog or an invalid dialog(different call-id and tags)).
>
>> > - i've moved the loading of dialogs to the first child (rather than
>> > during the initialization of the module),
>> >
>> This is good to have, it is fine with me.
>
> I think, this will also speed-up the starting of Kamailio ... ;-)
>
>>
>> > - i'll execute the create_dlg-callbacks when loading from database at
>> > startup. We do billing based on the dialog module, so we need the
>> > callbacks, when a dialog terminates... (and the callbacks should also be
>> > executed, if the proxy was restarted in the meanwhile ;-)
>> >
>> Perhaps this should be controlled via some module parameter. I haven't
>> developed on top of the dialog module that much and don't know the
>> compatibility impact, other may have different opinion, though.
>
> I think, i'll investigate a little further here. An option may be, to
> disable this upon loading via module parameter or to make this
> optionally configurable by each module registering a callback to the
> dialog-module...
>
> Thanks for your feedback.
>
> Carsten
>
>> Cheers,
>> Daniel
>>
>> > In case there are no objections to these changes, i will port them to
>> > SVN-Trunk and commit them to the SVN-tree.
>> >
>> > Kind regards,
>> > Carsten
>> >
>> >
>> > _______________________________________________
>> > Devel mailing list
>> > Devel at lists.kamailio.org
>> > http://lists.kamailio.org/cgi-bin/mailman/listinfo/devel
>> >
>>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.kamailio.org
> http://lists.kamailio.org/cgi-bin/mailman/listinfo/devel
>