[Kamailio-Devel] RFC: Dialog: Feature-Extensions

[Daniel-Constantin Mierla]

Hello

On 09/16/08 19:04, Carsten Bock wrote:
> Hi,
>
> Am Dienstag, den 16.09.2008, 18:18 +0300 schrieb Daniel-Constantin
> Mierla: 
>   
>> Hello Carsten,
>>
>>
>> On 09/16/08 17:58, Carsten Bock wrote:
>>     
>>> Hi,
>>>
>>> I have some extensions for the dialog module (currently for the
>>> 1.3-release, but i could also port it easily to SVN-Trunk):
>>> - in case "tight matching" fails (when using the Record-Route-Parameter
>>> for in-dialog requests), try to find the dialog based on the
>>> SIP-Elements in the message
>>>   
>>>       
>> isn't this already integrated, or I misunderstood?
>>
>> http://www.kamailio.org/docs/modules/1.4.x/dialog.html#id2467954
>>
>>     
>
> the current state is, that it checks for the existence of the cookie. If
> no cookie present, it will try perform a lookup based on
> SIP-credentials. The change will also perform the lookup, if the cookie
> is present but contains invalid information (e.g. points either to no
> dialog or an invalid dialog(different call-id and tags)).
>   

clear now, thanks. Indeed would be good to have.

>   
>>> - i've moved the loading of dialogs to the first child (rather than
>>> during the initialization of the module),
>>>   
>>>       
>> This is good to have, it is fine with me.
>>     
>
> I think, this will also speed-up the starting of Kamailio ... ;-)
>   

Right, the reason is done like this for usrloc module.


>   
>>> - i'll execute the create_dlg-callbacks when loading from database at
>>> startup. We do billing based on the dialog module, so we need the
>>> callbacks, when a dialog terminates... (and the callbacks should also be
>>> executed, if the proxy was restarted in the meanwhile ;-)
>>>   
>>>       
>> Perhaps this should be controlled via some module parameter. I haven't 
>> developed on top of the dialog module that much and don't know the 
>> compatibility impact, other may have different opinion, though.
>>     
>
> I think, i'll investigate a little further here. An option may be, to
> disable this upon loading via module parameter or to make this
> optionally configurable by each module registering a callback to the
> dialog-module...
>   
ok. I guess the features can be added in steps.

Cheers,
Daniel

-- 
Daniel-Constantin Mierla
http://www.asipto.com