[Kamailio-Devel] append_branch() inside modules

Klaus Darilion klaus.mailinglists at pernau.at
Fri Nov 28 12:43:23 CET 2008



Iñaki Baz Castillo schrieb:
> El Viernes, 28 de Noviembre de 2008, Klaus Darilion escribió:
>> regarding other branch parameters which were not copied
>> (duri, send_socket, bflags ...) - this should be reviewed too.
> 
> Why should be bflags copied when appending a new branch manually?

Example: You want to create 2 branches with different settings:
1. set RURI, set bflag, set send_socket
2. append branch()
3. set RURI, set bflag, set send_socket

regards
klaus
> 
> PD: As a suggestion, what I don't like is the possibility of handling bflags 
> out of branch_route. It causes confussion, for example:
> - User registered in two location, one natted and one not natted.
> - If we check the bflag(NATTED) in a route block we can get 1 or 0 depending 
> on which location appears first in the location table (or memory).
> 
> So, I suggest to just allow functions setbflag(), isbflagset(), 
> resetbflag()... in branch_route and onreply_route. Does it make sense? could 
> it break something? (well, sure it can break malfored scripts using bflags on 
> route blocks).
> 



More information about the Devel mailing list