[Kamailio-Devel] [SR-Dev] append_branch() inside modules

[Andrei Pelinescu-Onciul]

On Nov 28, 2008 at 01:04, Daniel-Constantin Mierla <miconda at gmail.com> wrote:
> Hello,
> 
> there are couple of modules that change the R-URI and automatically call 
> append_branch() if the execution takes place in failure_route, other 
> modules don't.
> 
> Perhaps we should get to a coherent behavior, if not for existing code, 
> then for the future. Probably the most flexible, better in my opinion, 
> is to let script writer to call append_branch() in config -- once done, 
> it is no way now to revert. A new branch should be automatically done 
> only if it is a specific operation, e.g., location lookup with more than 
> one record.
> 
> What do you think?

I agree, the script writer should call append_branch explicitly in the
script.


> 
> Cheers,
> Daniel
> 
> PS. this blending of the ser-kamailio sources gives me ideas to do some 
> cleanup as I review the code ... especially after midnight ...

You're not the only one, I have a hard time abstaining :-)

Andrei