[OpenSER-Devel] [ openser-Bugs-1912485 ] permissions: Ignoring default_allow parameter

Tue Mar 25 12:40:26 CET 2008

Bugs item #1912485, was opened at 2008-03-12 09:59
Message generated for change (Comment added) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1912485&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: None
Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: permissions: Ignoring default_allow parameter

Initial Comment:
during setup of permissions module I found that module parameters
"default_allow_file" and "default_deny_file" doesn't seem to work as
expected.

No mater what filename I configured permissions.so always checks for
"permissions.allow" resp. "permissions.deny" files in openser's main
config directory.

Here is openser's level 3 console output:

Mar 11 16:25:49 [3235] WARNING:core:main: no fork mode
Mar 11 16:25:49 [3235] INFO:core:init_tcp: using epoll_lt as the TCP io
watch method (auto detected)
Mar 11 16:25:49 [3235] NOTICE:core:main: version: openser
1.4.0dev0-notls (x86_64/linux)
Mar 11 16:25:49 [3235] INFO:core:main: using 32 Mb shared memory
Mar 11 16:25:49 [3235] INFO:core:main: using 1 Mb private memory per process
Mar 11 16:25:49 [3235] INFO:xlog:mod_init: initializing...
Mar 11 16:25:49 [3235] INFO:sl:mod_init: Initializing StateLess engine
Mar 11 16:25:49 [3235] INFO:tm:mod_init: TM - initializing...
Mar 11 16:25:49 [3235] INFO:maxfwd:mod_init: initializing...
Mar 11 16:25:49 [3235] INFO:usrloc:ul_init_locks: locks array size 512
Mar 11 16:25:49 [3235] INFO:registrar:mod_init: initializing...
Mar 11 16:25:49 [3235] INFO:textops:mod_init: initializing...
Mar 11 16:25:49 [3235] INFO:auth:mod_init: initializing...
Mar 11 16:25:49 [3235] INFO:auth_db:mod_init: initializing...
Mar 11 16:25:49 [3235] INFO:avpops:avpops_init: initializing...
Mar 11 16:25:49 [3235] WARNING:permissions:parse_config_file: file not
found: etc/openser/permissions.allow
Mar 11 16:25:49 [3235] WARNING:permissions:mod_init: default allow file
(etc/openser/permissions.allow) not found => empty rule set
Mar 11 16:25:49 [3235] WARNING:permissions:parse_config_file: file not
found: etc/openser/permissions.deny
Mar 11 16:25:49 [3235] WARNING:permissions:mod_init: default deny file
(etc/openser/permissions.deny) not found => empty rule set

And here is my permissions config:

# -- permissions --
loadmodule "permissions.so"
modparam("permissions", "default_allow_file", "permissionddds.allow")
modparam("permissions", "default_deny_file",
"/opt/app/voip/openser/etc/permissionddds.deny")
modparam("permissions", "check_all_branches", 1)
modparam("permissions", "allow_suffix", ".allow")
modparam("permissions", "deny_suffix", ".deny")
modparam("permissions", "address_table", "address")
modparam("permissions", "grp_col", "grp")
modparam("permissions", "ip_addr_col", "ip_addr")
modparam("permissions", "mask_col", "mask")
modparam("permissions", "port_col", "port")
modparam("permissions", "db_mode", 0)
modparam("permissions", "trusted_table", "trusted")
modparam("permissions", "source_col", "src_ip")
modparam("permissions", "proto_col", "proto")
modparam("permissions", "from_col", "from_pattern")
modparam("permissions", "tag_col", "tag")
modparam("permissions", "peer_tag_avp", "")

I use openser 1.4 build 3384

regards
helmut

----------------------------------------------------------------------

>Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-03-25 13:40

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Helmut,

each time I send you an email, I get an mailman error - The message could
not be delivered - not sure what are the reasons. My replies were getting
through on the mailing list:
http://lists.openser.org/pipermail/users/2008-March/016419.html

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Helmut Kuper (hekuper)
Date: 2008-03-17 15:57

Message:
Logged In: YES 
user_id=1851349
Originator: NO

Hi Bogdan,

not, I havn't got your mail on users list. I just searched for it, but
there is no ACK-Mail from you :)

regards
Helmut

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2008-03-12 16:15

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Helmut,

I fixed this bug in trunk - see rev 3679

Regards,
Bogdan

PS: haven't you got my email on users list?!!

----------------------------------------------------------------------

Comment By: Helmut Kuper (hekuper)
Date: 2008-03-12 10:46

Message:
Logged In: YES 
user_id=1851349
Originator: NO

Hello,

I fixed the bug in permissions module:

in File permissions.c funtion "static int mod_init(void)"

replace line (around line 690)

allow[0].filename = get_pathname(DEFAULT_ALLOW_FILE);

with

allow[0].filename = get_pathname(default_allow_file);

and replace line (around line 699)

deny[0].filename = get_pathname(DEFAULT_DENY_FILE);

with

deny[0].filename = get_pathname(default_deny_file);

then compile and reinstall it or just replace old permissions.so with
the newly compiled one.

regards
Helmut

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1912485&group_id=139143