[OpenSER-Devel] SF.net SVN: openser: [4402] trunk

[Henning Westerholt]

On Monday 30 June 2008, Bogdan-Andrei Iancu wrote:
> The history you removed consists of various notes that the developer
> made while adding or changing the code. There like comment which
> sometime prove useful (at least for me, while tracing some code).
>
> Also, I'm not sure why "the really old ones don't matter any more". Also
> it is not duplicate information (with SVN) - the code can be kept and
> delivered in a non SVN context (like tarballs) - in this case you will
> loose all the history information.

Hello Bogdan,

i don't want to devaluate the history. They would just have more value if they 
were up to date. In most cases there were no recent (say, the last two or 
three years) additions done to this entries, even if there were quite a lot 
of changes done (according to the svn logs) to the files in this time. So in 
my opinion they paint a misleading picture of the file history.

And i don't buy your argument with the non SVN context. Its really easy to 
just take a look to the svn, or to the Changelog, which happens to contain 
all the commit messages for all files in this specific release.

> I do not agree with removing any developer comments or notes from the
> code and I will suggest reverting that part of the commit.

Well, outdated or misleading comments are wrong then no comments at all. So i 
removed for example stuff like this during the DB API rework. I think it 
makes more sense to just write a good log message during commit instead of 
maintaining a copy of this information in the copyright block. There is a 
value in having a uniform file header, it saves (human) parsing time. :-)

But i'll take a look and add this again. This question will probably come up 
again in the next release.. ;-)

Thanks and regards,

Henning