[OpenSER-Devel] SF.net SVN: openser: [4402] trunk

[Bogdan-Andrei Iancu]

Hi Henning,

The history you removed consists of various notes that the developer 
made while adding or changing the code. There like comment which 
sometime prove useful (at least for me, while tracing some code).

Also, I'm not sure why "the really old ones don't matter any more". Also 
it is not duplicate information (with SVN) - the code can be kept and 
delivered in a non SVN context (like tarballs) - in this case you will 
loose all the history information.

I do not agree with removing any developer comments or notes from the 
code and I will suggest reverting that part of the commit.

Thanks and regards,
Bogdan

Henning Westerholt wrote:
> On Friday 27 June 2008, Bogdan-Andrei Iancu wrote:
>   
>> Hi Henning,
>>
>> This commit removed the history section from all affected files. Was
>> this on purpose or it was a miss ?
>>     
>
> Hi Bogdan,
>
> this was on purpose, as i stated in the commit message. I don't think that 
> duplicating this information in the header make much sense, as its also 
> present in the commit log messages of the repository. This information was in 
> most cases also not up to date, as recent changes were not reflected in the 
> history. Most of the developers don't bother to add detailed history to their 
> files.
>
> Informations from the SER project to the fork of OpenSER are lost, as this are 
> not present in our repository. If you think we're really need to know that in
>
>  *  2001-??-?? created by andrei
>  *  ????-??-?? lots of changes by a lot of people
>  *  2003-02-11 added inline msg_send (andrei)
>  *  2003-04-07 changed all ports to host byte order (andrei)
>  *  2003-04-12  FORCE_RPORT_T added (andrei)
>  *  2003-04-15  added tcp_disable support (andrei)
>
> there were that changes to the forward.h file (just to have an example) then i 
> need to take it back. But i don't think this is really relevant anymore.
>
> Cheers,
>
> Henning
>
>