[OpenSER-Devel] SF.net SVN: openser: [4329] trunk/modules/benchmark/benchmark.c

[Dan Pascu]

On Friday 06 June 2008, Henning Westerholt wrote:
> Hi Bogdan,
>
> i don't think that this method of marking each module function with the
> proper flags for every special route scale. Perhaps it makes sense to
> think a little bit about this, perhaps there exist a better way..
>
> Are there any objections against enabling this globally for all module
> functions? Perhaps its better to use a blacklist approach in the
> future, instead of the actual whitelist?

I disagree. There are functions that work in only 1 or 2 routes. They will 
require you to write more blacklists that whitelists, so overall you get 
the same thing, just reversed.

Besides this is not even the most important point. The most significant 
aspect is that a whitelist is a natural way of specifying where a 
function can run, while a blacklist is unnatural in this context because 
it uses negative logic.

Also you gain nothing. If a new route is added, where only a few functions 
work, you'll have to go and add all the other functions to the blacklist, 
much the same way you're trying to avoid to add most of the functions to 
the whitelist when most of them work in the new route.

-- 
Dan