[OpenSER-Devel] Major carrierroute reworking

[Ovidiu Sas]

Hello Henning,

First of all, thank you and Hardy Kahl for all the improvements inside
the carrierroute module.
Since the module is still under development, I would like to ask for a feature.
The new functions 'cr_route' and 'cr_load_next_domain' has a parameter
called 'dstavp' and it holds the rewritten host.
Since the host can be easily extracted from $ru, I would like to make
this avp generic and return a tag, just like for the trusted table:
http://www.openser.org/docs/modules/1.4.x/permissions.html#AEN343
http://www.openser.org/docs/modules/1.4.x/permissions.html#AEN332
http://www.openser.org/docs/modules/1.4.x/permissions.html#AEN501

This implies adding a new column to the cr tables and a new param for
the cr module.  Also, specifing the dstavp inside a param, will reduce
the number of arguments for the two functions.
Please let me know your thoughts.


Regards,
Ovidiu Sas

On Thu, Feb 28, 2008 at 1:10 PM, Henning Westerholt
<henning.westerholt at 1und1.de> wrote:
> On Thursday 28 February 2008, Henning Westerholt wrote:
>  > [..]
>
> > Because of this major changes there were probably quite a few new bugs
>  > introduced. Nevertheless any tests and of course comments to the new design
>  > are really appreciated.
>
>  Hi,
>
>  for the moment the module (at least the load_next_domain, and cr_route with
>  dest_avp) will not work correctly, as this functions tries to use more module
>  function parameter as available. ;-) Sure, this could be increased in the
>  core, but i think actually 6(7 in C API) should be enough. There is perhaps
>  some need to compact things a little bit.
>
>  I'll also add additional test for this module in the next days, then things
>  will stabilize probably.
>
>  Cheers,
>
>  Henning
>
>
>
>  _______________________________________________
>  Devel mailing list
>  Devel at lists.openser.org
>  http://lists.openser.org/cgi-bin/mailman/listinfo/devel
>