[OpenSER-Devel] irc on domains for rr module

[Bogdan-Andrei Iancu]

Hi Juha,

Yep, that was my initial view on fixing this issue, but I'm wondering if 
it pays the effort, mainly because:
    1) putting the domain list in core, with the reload functionality, 
will raise again sync problems....
    2) usually general solutions are more complicate (volume of work) to 
do implement than a particular solution
    3) for the moment the only need for domain list in core is because 
of rr-domain interaction, so not sure if a general solution is really 
needed..

But I will do more thinking on this...maybe I will find a middle 
solution....

Regards,
Bogdan

Juha Heinanen wrote:
> Bogdan-Andrei Iancu writes:
>
>  > The idea was to have all modules using a core function (like rr does 
>  > now) to check is a domain is local IP or domain, instead of having each 
>  > module to use a core function and a function from other module
>  > (domains)...
>
> in that case, domain module should also push the domains into core
> instead of keeping them in its own cache.  it makes no sense to have
> them in two places.  after that, there would be only one function in
> domain module (is_domain_local(pseudo_variable)) that would call
> corresponding core function, which means that perhaps then also
> this function should be pushed to core.  then the question is, what to
> do with domain_reload function?
>
> on the other hand, it is still don't understand, what the advantage
> would be if other modules call a core function instead of calling a
> function exported from domain module.  it would just make core bigger
> for someone who does not need domains at all.
>
> -- juha
>
>