[OpenSER-Devel] irc on domains for rr module

[Juha Heinanen]

Bogdan-Andrei Iancu writes:

 > The idea was to have all modules using a core function (like rr does 
 > now) to check is a domain is local IP or domain, instead of having each 
 > module to use a core function and a function from other module
 > (domains)...

in that case, domain module should also push the domains into core
instead of keeping them in its own cache.  it makes no sense to have
them in two places.  after that, there would be only one function in
domain module (is_domain_local(pseudo_variable)) that would call
corresponding core function, which means that perhaps then also
this function should be pushed to core.  then the question is, what to
do with domain_reload function?

on the other hand, it is still don't understand, what the advantage
would be if other modules call a core function instead of calling a
function exported from domain module.  it would just make core bigger
for someone who does not need domains at all.

-- juha