[OpenSER-Devel] [patch] Improvements for MSILO module

[Daniel-Constantin Mierla]

Hello,

please upload to the patch tracker.

If the offline message is parameter and can be text, HTML, ..., then the 
content type has to be parameter as well.

Using the destination in From of notifications might be misleading in 
some cases, but is good to have it as option, so I will make it as 
parameter, maybe if registrar="*" will induce this behavior.

Thanks,
Daniel


On 02/06/08 13:40, Iñaki Baz Castillo wrote:
> Hi, I've been playing a bit with msilo.c code and changed some things to make 
> it more flexible. The changes are made from SVN rev 3632.
>
>
> This is my changelog:
>
> - Notification "From" is now the original destination ("registrar" parameter 
> deleted). I think this is better since the sender won't see a new IM window 
> from a strange user when OpenSer dens back the notification. Instead it will 
> see it in the same IM window.
>
> - Added "offline_message" parameter allowing HTML. So the admin could set him 
> own notification message in openser.cfg. If not set, the default value is:
>   "<em>I'm offline. The message will be delivered when I'm online.</em>"
>
> - Deleted "Contact" header in notification (not necessary in MESSAGE since 
> MESSAGE doesn't establish a dialog).
>
> - Deleted CONTACT* and OFFLINE_MESSAGE* #defines and buf1[1024] (not necessary 
> now)
>
> - Added HEADERS #define to set "Content-Type" header as "text/html".
>
>
> I've tested it and seems to work correctly, what do you think about those 
> changes? could they be submitted (with updated doc of course)?
>
>
> Regards.
>
>
>
>
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Devel mailing list
> Devel at lists.openser.org
> http://lists.openser.org/cgi-bin/mailman/listinfo/devel