[OpenSER-Devel] [OpenSER-Users] userblacklist

Helmut Kuper helmut.kuper at ewetel.de
Tue Apr 29 09:36:53 CEST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Henning,

Henning Westerholt schrieb:

| Hello Helmut,
|
| i thought a little more about this issue, and i just ported your first
patch,
| without the 'old' interface change. It provides more consistency with the
| check_blacklist function. Sorry for the double work.

np, that one was just a seconds lasting small hack ;)

| I don't used your logic (just copy with strncpy up to the MAXNUMBERLEN
size),
| this does much to work for most of the cases, as its fills the string
with
| unneeded zeros. I just use the existing approach, check if the number
length
| is smaller or equal the MAXNUMBERLEN.

Ok, I also thought about that way, but using a single strncpy command
was to sexy ... ;) In terms of performance your way is faster I think
(depending of MAXNUMBERLEN size of course).

~ > I just used the same logic that is actually implemented in the
carrierroute
| module. All non-numerical chars in front of the number are skipped.
|
This should work for me as well.

As soon as the patch is applied I will test it.

Thx and regards
Helmut

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkgW0BUACgkQ4tZeNddg3dzW4gCePZEKdO57gg1EkWBgL4sRN1mL
5fcAoIbHytfAkPG+rqv9FqMJSP+BmIFt
=aON1
-----END PGP SIGNATURE-----



More information about the Devel mailing list