[OpenSER-Devel] [ openser-Patches-1745026 ] allowing extra attributes in RADIUS-based modules

[SourceForge.net]

Patches item #1745026, was opened at 2007-06-28 22:14
Message generated for change (Comment added) made by juhe
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1745026&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Victor Gamov (vitspec)
Assigned to: Nobody/Anonymous (nobody)
Summary: allowing extra attributes in RADIUS-based modules

Initial Comment:
Hi guys!

The following patch add "extra attributes" feature in AUTH_RADIUS and URI_RADIUS modules.
New config parameter "radius_extra" for patched modules added.

Currently we use this feature to add really useful attributes into RADIUS request, for example:

modparam("auth_radius", "radius_extra", "Called-Station-Id=$tu;Calling-Station-Id=$fu")

This code based on "extra accounting" feature from ACC module. Many thanks to Ramona!

----------------------------------------------------------------------

>Comment By: Juha Heinanen (juhe)
Date: 2008-04-19 17:03

Message:
Logged In: YES 
user_id=1332122
Originator: NO

i looked at the patches and have a couple of comments:

- in order to cleanly separate the new code, i would like to include a
test if extra attributes are present to sterman.c and checks.c before
add_extra_2_radius is called.

- uri_radius module includes extra_attrs.h from auth_radius module.  i
don't know if that is according to openser policy.  if there is common
code, perhaps it should be included in core.

- documentation diffs should also be included.

-- juha

----------------------------------------------------------------------

Comment By: Victor Gamov (vitspec)
Date: 2007-09-22 22:08

Message:
Logged In: YES 
user_id=1625470
Originator: YES

RADIUS attributes with type IP-Address (like Framed-IP-Address) processed
correctly now
(patch for 1.2.1 still)
File Added: patch-radius_extra_attrs.tar

----------------------------------------------------------------------

Comment By: Victor Gamov (vitspec)
Date: 2007-08-14 21:21

Message:
Logged In: YES 
user_id=1625470
Originator: YES

Hi All !

is this patch tested somebody ?

if any problems with it please email me and I'll try to help or make
improovment

Thanks

----------------------------------------------------------------------

Comment By: Victor Gamov (vitspec)
Date: 2007-06-28 23:18

Message:
Logged In: YES 
user_id=1625470
Originator: YES

right (I hope :-) ) archive attached 
File Added: patch-extra_attrs.tar

----------------------------------------------------------------------

Comment By: Victor Gamov (vitspec)
Date: 2007-06-28 23:05

Message:
Logged In: YES 
user_id=1625470
Originator: YES

oops!  incorrect patch attached. wait a moment!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1745026&group_id=139143