[OpenSER-Devel] SF.net SVN: openser: [3972] trunk

[Daniel-Constantin Mierla]

Hi Adrian,

On 04/03/08 21:26, Adrian Georgescu wrote:
> Hi Henning,
>
> You are often making changes with impact on many different places.  
> While I am not the one to judge all these changes in detail, please  
> bear in mind that you are not the only one using this software.  
> Additions are great, but changes to exiting code is a different thing  
> and your should consult the developer of the modules in question.
>   
for this case, it was -- on the tracker I agreed with the changes in the 
siptrace schema. I considered that a clean naming for all DB systems is 
easy to maintain and use from additional tools of openser. As said in a 
previous email, that column name was a bad choice, very exposed to this 
case. In the past, similar issues were solved by renaming and long term 
should be the best to keep all the related tools in the openser 
environment clean and smooth in updating to new versions.

Cheers,
Daniel

> Such dramatic changes cannot be scrutinized for correctness or  
> usefulness at the rate you commit them and this could be the reason  
> for the so many bugs recently introduced that nobody can trace the  
> source for.
>
> No offence
>
> Adrian
>
> On Apr 3, 2008, at 6:37 PM, Henning Westerholt wrote:
>
>   
>> Revision: 3972
>>           http://openser.svn.sourceforge.net/openser/? 
>> rev=3972&view=rev
>> Author:   henningw
>> Date:     2008-04-03 09:37:35 -0700 (Thu, 03 Apr 2008)
>>
>> Log Message:
>> -----------
>> - preparations for db_oracle driver merging
>> - rename column names that uses reserved words from oracle
>> - update siptrace code and carrierroute documentation
>> - siptrace table version increased, but this is not checked in code  
>> anyway
>> - carrierroute code changed as comment is displayed from setup tools
>> - the other modules don't use the colum in question, its only a  
>> comment
>>   so no version update is necessary
>> - SQL scheme files and documentation also updated
>> - Patch provided from Iouri Kharon, yjh at styx dot cabel dot net
>>
>> Modified Paths:
>> --------------
>>     trunk/db/schema/carrierfailureroute.xml
>>     trunk/db/schema/carrierroute.xml
>>     trunk/db/schema/domainpolicy.xml
>>     trunk/db/schema/globalblacklist.xml
>>     trunk/db/schema/sip_trace.xml
>>     trunk/db/schema/userblacklist.xml
>>     trunk/modules/carrierroute/README
>>     trunk/modules/carrierroute/carrierroute.c
>>     trunk/modules/carrierroute/doc/carrierroute_admin.xml
>>     trunk/modules/siptrace/siptrace.c
>>     trunk/scripts/db_berkeley/openser/carrierfailureroute
>>     trunk/scripts/db_berkeley/openser/carrierroute
>>     trunk/scripts/db_berkeley/openser/domainpolicy
>>     trunk/scripts/db_berkeley/openser/globalblacklist
>>     trunk/scripts/db_berkeley/openser/sip_trace
>>     trunk/scripts/db_berkeley/openser/userblacklist
>>     trunk/scripts/db_berkeley/openser/version
>>     trunk/scripts/dbtext/openser/carrierfailureroute
>>     trunk/scripts/dbtext/openser/carrierroute
>>     trunk/scripts/dbtext/openser/domainpolicy
>>     trunk/scripts/dbtext/openser/globalblacklist
>>     trunk/scripts/dbtext/openser/sip_trace
>>     trunk/scripts/dbtext/openser/userblacklist
>>     trunk/scripts/dbtext/openser/version
>>     trunk/scripts/mysql/carrierroute-create.sql
>>     trunk/scripts/mysql/domainpolicy-create.sql
>>     trunk/scripts/mysql/siptrace-create.sql
>>     trunk/scripts/mysql/userblacklist-create.sql
>>     trunk/scripts/postgres/carrierroute-create.sql
>>     trunk/scripts/postgres/domainpolicy-create.sql
>>     trunk/scripts/postgres/siptrace-create.sql
>>     trunk/scripts/postgres/userblacklist-create.sql
>>
>>
>> This was sent by the SourceForge.net collaborative development  
>> platform, the world's largest Open Source development site.
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.openser.org
>> http://lists.openser.org/cgi-bin/mailman/listinfo/devel
>>     
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.openser.org
> http://lists.openser.org/cgi-bin/mailman/listinfo/devel
>   

-- 
http://www.asipto.com