[OpenSER-Devel] [ openser-Bugs-1803444 ] Carrier-Route: DB-Schema and cr_tree_rewrite_uri (Fix)

[SourceForge.net]

Bugs item #1803444, was opened at 2007-09-27 12:27
Message generated for change (Comment added) made by carstenbock
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1803444&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Carsten Bock (carstenbock)
Assigned to: Henning Westerholt (henningw)
Summary: Carrier-Route: DB-Schema and cr_tree_rewrite_uri (Fix)

Initial Comment:
Hi,

after playing a little bit around with the carrier-route module, i found two little bugs:
1) in the DB-Schema, the strip-parameter was defined as an String, not as an int. The module retrieves the int-value (although it is a string) and this results into a strange behaviour; at least in some cases (my setup: mysql-client 4.1.x and Server 5.x).
See attached patch: carrierroute_db_schema.patch
2) when playing around with "cr_tree_rewrite_uri", i've noticed that
a) it uses the default tree, not the tree provided as parameter.
b) the fixup function return the number in the tree, not the id of the carrier.
The attached patch "carrierroute_tree_route_uri.patch" fixes these issues.

Carsten

----------------------------------------------------------------------

>Comment By: Carsten Bock (carstenbock)
Date: 2007-09-27 16:28

Message:
Logged In: YES 
user_id=1488991
Originator: YES

Hi Henning,

Thanks for the clarification about the use of the internal and external
id. Now it's clear for me.
I have adapted the patch regarding the use of AVP's to your latest
changes.

Carsten
File Added: carrierroute_tree_route_uri.patch

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-09-27 16:00

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hey, there was a overlapping in our changes.. Reopen because the patch is
not integrated yet.

Cheers,

Henning

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-09-27 15:58

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hello Carsten,

thank you for the report and patches! 
Regarding the db, this error was introduced at the porting to the xml
schema. 

The fix you've suggested was right, but its easier to use the given tree
parameter.
The second change (tmp->no..) was not correct. This module don't use the
external IDs,
e.g. from the database for the internal datastructures. This could lead to
not optimal
results, for example if some user specify a id of 100000..
I've added a comment that hopefully explains it a little bit.


Commited in revision 2831.

Henning

----------------------------------------------------------------------

Comment By: Carsten Bock (carstenbock)
Date: 2007-09-27 15:39

Message:
Logged In: YES 
user_id=1488991
Originator: YES

Actually more or less not only an fix, but also a feature extension:
the cr_tree_rewrite_uri-method now also accepts pseudo-variables for the
carrier-name.
Tha patch is against the latest SVN-Version.
File Added: carrierroute_tree_route_uri.patch

----------------------------------------------------------------------

Comment By: Carsten Bock (carstenbock)
Date: 2007-09-27 14:31

Message:
Logged In: YES 
user_id=1488991
Originator: YES

added the fix (as just applied to user_route_fixup in SVN-Tree)
File Added: carrierroute_tree_route_uri.patch

----------------------------------------------------------------------

Comment By: Carsten Bock (carstenbock)
Date: 2007-09-27 12:27

Message:
Logged In: YES 
user_id=1488991
Originator: YES

File Added: carrierroute_tree_route_uri.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1803444&group_id=139143