[OpenSER-Devel] [ openser-Bugs-1791953 ] missing dialog callback for ACK (dialog module)

[SourceForge.net]

Bugs item #1791953, was opened at 2007-09-10 16:41
Message generated for change (Comment added) made by osas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1791953&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Bogdan (bogdan_iancu)
Summary: missing dialog callback for ACK (dialog module)

Initial Comment:
Dialog callback are not run for ACKs.
Here's a small patch (for dev version) that will fix the issue.  Same patch can be applied to 1.2.

# svn diff
Index: dlg_handlers.c
===================================================================
--- dlg_handlers.c	(revision 2733)
+++ dlg_handlers.c	(working copy)
@@ -613,7 +613,7 @@
 		return;
 	}
 
-	if (event==DLG_EVENT_REQ && new_state==DLG_STATE_CONFIRMED) {
+	if ((event==DLG_EVENT_REQ || event==DLG_EVENT_REQACK) && new_state==DLG_STATE_CONFIRMED) {
 		DBG("DEBUG:dialog:dlg_onroute: sequential request successfully "
 			"processed\n");
 		dlg->lifetime = get_dlg_timeout(req);


----------------------------------------------------------------------

>Comment By: Ovidiu Sas (osas)
Date: 2007-10-22 11:45

Message:
Logged In: YES 
user_id=1395524
Originator: YES

The right patch for this one would be to check only for ACK -
DLG_EVENT_REQACK (no need to chack for DLG_EVENT_REQ):
Index: modules/dialog/dlg_handlers.c
===================================================================
--- modules/dialog/dlg_handlers.c	(revision 2967)
+++ modules/dialog/dlg_handlers.c	(working copy)
@@ -590,7 +590,7 @@
 		return;
 	}
 
-	if (event==DLG_EVENT_REQ && new_state==DLG_STATE_CONFIRMED) {
+	if (event==DLG_EVENT_REQACK && new_state==DLG_STATE_CONFIRMED) {
 		LM_DBG("sequential request successfully processed\n");
 		dlg->lifetime = get_dlg_timeout(req);
 		if (update_dlg_timer( &dlg->tl, dlg->lifetime )!=-1) {

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1791953&group_id=139143