[OpenSER-Devel] [ openser-Bugs-1752578 ] locally generated ACKs with bad Route header from ReINVITE

[SourceForge.net]

Bugs item #1752578, was opened at 2007-07-12 15:13
Message generated for change (Settings changed) made by bogdan_iancu
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752578&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver 1.2.x
Status: Open
Resolution: Accepted
>Priority: 8
Private: No
Submitted By: Henning Westerholt (henningw)
Assigned to: Bogdan-Andrei Iancu (bogdan_iancu)
Summary: locally generated ACKs with bad Route header from ReINVITE

Initial Comment:
(Now correctly as bug, and not as patch..)

Hello,

we've noticed that in the ACKs generated locally for a ReINVITE a wrong Route header field is present. 
Example call flow scenario:
 
- ReINVITE from localhost client to local openser
- 100 from openser to client
- INVITE from openser to local sipp
- 488 error msg from sipp to openser
- ACK with unwanted Route header from openser to sipp
 
The Route header field is copied from the initial INVITE, and not from the INVITE that he has sended.
 
This issue was previously reported in the bug: 1531781 - "Locally generated single-hop ACKs with bad Route header".
 
It seems the fix was not applied, or there was a regression.
 
This problem is reproduceable with 1.2 and recent trunk versions.
 
The necessary data to reproduce this bug is attached, the file includes also a wireshark dump showing the problem.
 
Cheers,
 
Henning

----------------------------------------------------------------------

Comment By: Bogdan-Andrei Iancu (bogdan_iancu)
Date: 2007-07-25 16:38

Message:
Logged In: YES 
user_id=1275325
Originator: NO

Hi Henning,

As the ACK is built based on the received INVITE (and not sent INVITE),
the local route hdr will be copied also, which is not correct. The problem
is that there is not sent INVITE structure to be used for building the
ACK/CANCELs....
Probably the solution will be to have the local-Route(s) marked by RR
module when doing loose_route() and build_local() to ignore the marked R
headers....
....just a first idea.

Regards,
Bogdan

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-07-12 18:13

Message:
Logged In: YES 
user_id=337916
Originator: YES

The problem belongs probably to t_msgbuilder::build_local(), for non-local
transactions the complete route header will be copied. So the belonging
transaction is accounted as non-local, and the wrong INVITE message is
referenced.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1752578&group_id=139143