[OpenSER-Devel] Patch submission

[Morgan Gilroy]

Yeah I know it's a quick hack :), Im new to OpenSER and this is the
first time iv even looked a the code.

If I get time ill try implement a better way to do it (after iv had a
chance to understand how the pdtree works).

Thanks.

-----Original Message-----
From: Elena-Ramona Modroiu [mailto:ramona at voice-system.ro] 
Sent: 27 June 2007 17:53
To: Morgan Gilroy
Cc: devel at openser.org
Subject: Re: [OpenSER-Devel] Patch submission

Hi,

the idea is working, but something is missing. PDT_NODE_SIZE should be 
increased to 16, otherwise it does not work properly. Also the MI 
functions should be adapted to the new set of accepted characters. 

With this patch there will be allowed a set of 16 characters: * + ,  - .

/ 0 1 2 3 4 5 6 7 8 9 . Five more characters than you need.  This also 
means an increase in the size of the trees (each node having 16 sons), 
that is the memory allocated. For this reason, I do not like very much 
this solution.  It's working but it's not optimal. I would go for a 
generalized solution that allows all printable characters and in the 
same time avoiding to allocate too much memory. For example, making use 
of a dictionary to define the set of characters allowed in the prefix. 
This way, PDT_NODE_SIZE will reflect only the needed characters and have

a lower value. I will think about if it's worthy ... maybe a better idea

will show up.

Thanks for the patch and for pointing out this kind of use case.

Regards,
Ramona


Elena-Ramona Modroiu wrote:
> OK, I see ...  I will have a look at it.
>
> Regards,
> Ramona
>
>
> Morgan Gilroy wrote:
>> Yes I saw this before, but unfortunately not all prefixes begin with
a
>> *, some begin with **, some are just numbers like 75.
>> Basically they can be anything including *
>>
>> -----Original Message-----
>> From: Elena-Ramona Modroiu [mailto:ramona at voice-system.ro] Sent: 26 
>> June 2007 08:40
>> To: Morgan Gilroy
>> Cc: Klaus Darilion; devel at openser.org
>> Subject: Re: [OpenSER-Devel] Patch submission
>>
>> Hi,
>>
>> for the needs you describe, just setting in the configuration file 
>> the "prefix" parameter of the module ( like this: modparam("pdt", 
>> "prefix", "*")) should do it.
>>
>> Regards,
>> Ramona
>>
>>
>> Morgan Gilroy wrote:
>>  
>>> Thanks,
>>> Issue: 1742883
>>>
>>> I hope it's alright.
>>> (Im new to this :) )
>>>
>>> -----Original Message-----
>>> From: Klaus Darilion [mailto:klaus.mailinglists at pernau.at] Sent: 25 
>>> June 2007 15:17
>>> To: Morgan Gilroy
>>> Cc: devel at openser.org
>>> Subject: Re: [OpenSER-Devel] Patch submission
>>>
>>>
>>>
>>> Morgan Gilroy wrote:
>>>      
>>>> Hi, I have a simple patch to allow the use of * (asterisk) in the
PDT
>>>> module (at the moment it only allows 0-9 as the first digit), id
like
>>>>           
>>> to
>>>      
>>>> submit it.
>>>>
>>>> What is the process for this?
>>>> Just post it on a note on sourceforge.net tracker under patches?
>>>>           
>>> yes
>>>
>>>      
>>>> What options should I use for the diffs ?
>>>>           
>>> unified: -u
>>>
>>> regards
>>> klaus
>>>
>>>
______________________________________________________________________
>>> This email has been scanned by the MessageLabs Email Security
System.
>>> For more information please visit http://www.messagelabs.com/email 
>>>
______________________________________________________________________
>>>
>>> _______________________________________________
>>> Devel mailing list
>>> Devel at openser.org
>>> http://openser.org/cgi-bin/mailman/listinfo/devel
>>>       
>>
>>
>>
______________________________________________________________________
>> This email has been scanned by the MessageLabs Email Security System.
>> For more information please visit http://www.messagelabs.com/email 
>>
______________________________________________________________________
>>   
>
>
> _______________________________________________
> Devel mailing list
> Devel at openser.org
> http://openser.org/cgi-bin/mailman/listinfo/devel


______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________