[OpenSER-Devel] [ openser-Patches-1707527 ] add dbtext support via openserctl

[SourceForge.net]

Patches item #1707527, was opened at 2007-04-25 12:01
Message generated for change (Comment added) made by osas
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1707527&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tools
Group: ver devel
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ovidiu Sas (osas)
Assigned to: Nobody/Anonymous (nobody)
Summary: add dbtext support via openserctl

Initial Comment:
Hi,

This patch integrates dbtext support into the openserctl script:
 - openserctl.patch - patch for openserctl script
 - openserctl.dbtext - new file to be installed

This aims to add proper support for dbtext out of the box and hopefully better maintenance for dbtext.

Todo: fix the Makefile to properly install the new openserctl.dbtext file (not included in the patch)

----------------------------------------------------------------------

>Comment By: Ovidiu Sas (osas)
Date: 2007-07-13 17:57

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Hi Henning,

Tested ok.
The only remaining issue is the id(int,auto).

Regards,
Ovidiu

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-07-13 10:31

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hi Ovidiu,

the problems you mentioned in the comment from "2007-07-12 17:50" should
be fixed. Perhaps you can give it another try.

Regards,

Henning

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2007-07-12 14:42

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Hi Henning,

Another thing that I noticed is that lots of tables are having the
id(int,auto) field, but the openserctl script is not populating this script
for DBTEXT.


Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2007-07-12 13:50

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Hi Henning

It seems that DBTEXT_PATH is ignored by openserdbctl when the dbtext
database is created.
Also, DBTEXT should be listed as a valid token inside the openserctlrc,
along with the DBTEXT_PATH variable.


Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-07-10 07:27

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hello Ovidiu,

i've finished the integration of your patch. I've made a few small changes
to some user output messages, and removed the dbtext creation function, as
this should be handled from the openserdbctl script. Furthermore i have
tried to use the common definitions from openserctl.base as much as
possible.

I've made some basic tests, but it would be nice if you could test the
dbtext part a little bit more extensive.

Thank you,

Henning

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2007-07-05 09:10

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Hi Henning,

Yes, dbtext has this limitation.  Pls. check with miconda about patch
1671120:
https://sourceforge.net/tracker/index.php?func=detail&aid=1671120&group_id=139143&atid=743022
When this patch will be implemented, dbtext will perform properly.

I would say that for now, print a warning from the script with a reference
to patch 1671120.


Regards,
Ovidiu Sas

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-07-05 04:52

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hello Ovidiu,

i've some questions regarding your patch for openserctl:

In the domain() part, you output the message "..trying to force OpenSER to
reload it" but the necessary fifo_cmd domain_reload is not implemented.
Should i remove this part of user information? 

Or perhaps we can use the same approach like the other engines in this
part, output msg: "..use domain reload.."? Does the command "$CTLCMD
domain_reload" work for dbtext?

The same issue exist in the lcr() part of the patch. 
What do you think?

Henning

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2007-05-24 10:48

Message:
Logged In: YES 
user_id=1395524
Originator: YES

Hi Henning,

Please use the patch to update the openserctl.  I forgot that I updated
the openserctl in the pactch.

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2007-05-24 04:30

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hello Osas,

i have not looked into this database openserctl specific stuff yet, i
think i can use at least parts of your patch.

Perhaps Bogdan confuses this patch with your previous tracker entry
"sc.dbtext is not up to date for location/alias", this is allready fixed by
the new schema generation stuff. 

Henning

----------------------------------------------------------------------

Comment By: Ovidiu Sas (osas)
Date: 2007-05-23 14:11

Message:
Logged In: YES 
user_id=1395524
Originator: YES

This patch is no longer needed (in light of Henning Westerholt effort to
integrate all databases under the xml schema)

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743022&aid=1707527&group_id=139143