[OpenSER-Devel] [ openser-Bugs-1749253 ] memory-errors in modules/path/path.c

[SourceForge.net]

Bugs item #1749253, was opened at 2007-07-06 19:12
Message generated for change (Comment added) made by agranig
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1749253&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: modules
Group: ver 1.2.x
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Marcus Hunger (marcushunger)
Assigned to: Nobody/Anonymous (nobody)
Summary: memory-errors in modules/path/path.c

Initial Comment:
hi,
the path-module has two memory errors: a double-free in prepend_path and a memory-leak in path_rr_callback. 

the double-free-condition is triggered when an error happens after at least one insert_new_lump_before happened. then all allocated buffers get freed, including the one(s) that was added as a lump. freeing the packet and the lump leads to a double-free.

the memleak in path_rr_callback is caused by not freeing the whole params-list, but only the part of the list beginning with the received-parameter. 

the attached patch fixes these issues.

----------------------------------------------------------------------

Comment By: Andreas Granig (agranig)
Date: 2007-07-06 19:40

Message:
Logged In: YES 
user_id=825350
Originator: NO

Thanks. I'll do some more stress-tests and will then commit the patch by
end of next week.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1749253&group_id=139143