[Devel] acc diff

[Juha Heinanen]

Dan Pascu writes:

 > I was thinking that there can be an AVP that if set will be used as 
 > User-Name, else it will take it from where it takes it now (credentials 
 > or From)
 > That way you don't have to compute it 2 times, nor will there be 2 
 > attributes. Just set that AVP if you want the default overwritten.
 > 
 > something along the lines:
 > 
 > if (is_avp_set(some_avp_spec)) {
 >   take User-Name attribute from that AVP
 > } else {
 >   take User-Name attribute from credentials/from as now
 > }

i understand, but can't accept this kind of complexity in Radius
backend, when User-Name is NOT included in mysql etc. backends at all.

because there are NO technical nor standards reason to have User-Name in
Radius backend, Radius should not be treated differently from mysql
etc. backends and MUST NOT include User-Name in the minimal set.

other problem with overwriting is that in stop records i don't set
User-Name extra attribute at all and (the default) useless User-Name
would still be included.  this brings me to ask to drop also From header
URI from the minimal set, since is it is not needed in stop records.

so the minimum set should be this for all backends:

     * Request Method name
     * From header TAG parameter
     * To header TAG parameter
     * Cseq number
     * Call-Id
     * 3-digit Status code from final reply
     * Reason phrase from final reply
     * Time stamp when transaction was completed

i'm not sure about Cseq.  perhaps it could be dropped too.  why is it
included in the minimum set?

i hope to get this issue resolved soon so that we can continue with more
productive stuff.

-- juha