[sr-dev] [kamailio/kamailio] ims_usrloc_pcscf: implementation of db_mode DB_ONLY (value 3) (PR #3279)

petermarianF notifications at github.com
Wed Nov 9 16:22:42 CET 2022


In order to support a redundant PCSCF configuration - i.e. a logical PCSCF consists of 2 physical nodes (node1 and node2) some enhancements were introduced for handling of contacts. Redundancy means that SIP messages for a client are normally handled by node1 but in case node1 is not reachable SIP messages are redirected to node2. Of course the DB_ONLY mode must work also for single PCSCF node configuration. Important aspects of this implementation are database integrity - i.e. avoid invalid table entries (for example data which are expired long time ago or have invalid states) - and keeping PCSCF cache in sync with database tables. A wrapper was built for method get_pcontact which tries to find the pcontact in cache and if search is not successful tries to download and insert from db location table - also some effort is added here to find the pcontact if it exists in cache. The contact expiry handler was modified to sync contact expiry in cache with db location entry and in case of real contact expiry sends PUBLISH to SCSCF to let NOTIFY finally delete the contact. An audit for older expired pcontacts was introduced which cares for getting rid of these contacts.
So db queries for this db mode are only supported for Mysql.
Some code was introduced to help registering callbacks for contacts which are inserted into cache when being downloaded from database - for example ims_qos callback as at the time of insertion the message that triggered the original callback registering is long gone.

<!-- Kamailio Pull Request Template -->

<!--
IMPORTANT:
  - for detailed contributing guidelines, read:
    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
  - pull requests must be done to master branch, unless they are backports
    of fixes from master branch to a stable branch
  - backports to stable branches must be done with 'git cherry-pick -x ...'
  - code is contributed under BSD for core and main components (tm, sl, auth, tls)
  - code is contributed GPLv2 or a compatible license for the other components
  - GPL code is contributed with OpenSSL licensing exception
-->

#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally in local branch based on 5.5.4
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)

#### Description
<!-- see top of this section -->

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/3279

-- Commit Summary --

  * ims_usrloc_pcscf:   implementation of db_mode DB_ONLY (value 3)

-- File Changes --

    M src/modules/ims_usrloc_pcscf/README (11)
    M src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c (22)
    M src/modules/ims_usrloc_pcscf/pcontact.c (85)
    M src/modules/ims_usrloc_pcscf/udomain.c (511)
    M src/modules/ims_usrloc_pcscf/udomain.h (5)
    M src/modules/ims_usrloc_pcscf/ul_callback.c (52)
    M src/modules/ims_usrloc_pcscf/ul_callback.h (10)
    M src/modules/ims_usrloc_pcscf/ul_rpc.c (156)
    M src/modules/ims_usrloc_pcscf/usrloc.c (7)
    M src/modules/ims_usrloc_pcscf/usrloc.h (12)
    M src/modules/ims_usrloc_pcscf/usrloc_db.c (50)
    M src/modules/ims_usrloc_pcscf/usrloc_db.h (2)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/3279.patch
https://github.com/kamailio/kamailio/pull/3279.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3279
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/3279 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20221109/834ea13f/attachment.htm>


More information about the sr-dev mailing list