<p dir="auto">In order to support a redundant PCSCF configuration - i.e. a logical PCSCF consists of 2 physical nodes (node1 and node2) some enhancements were introduced for handling of contacts. Redundancy means that SIP messages for a client are normally handled by node1 but in case node1 is not reachable SIP messages are redirected to node2. Of course the DB_ONLY mode must work also for single PCSCF node configuration. Important aspects of this implementation are database integrity - i.e. avoid invalid table entries (for example data which are expired long time ago or have invalid states) - and keeping PCSCF cache in sync with database tables. A wrapper was built for method get_pcontact which tries to find the pcontact in cache and if search is not successful tries to download and insert from db location table - also some effort is added here to find the pcontact if it exists in cache. The contact expiry handler was modified to sync contact expiry in cache with db location entry and in case of real contact expiry sends PUBLISH to SCSCF to let NOTIFY finally delete the contact. An audit for older expired pcontacts was introduced which cares for getting rid of these contacts.<br>
So db queries for this db mode are only supported for Mysql.<br>
Some code was introduced to help registering callbacks for contacts which are inserted into cache when being downloaded from database - for example ims_qos callback as at the time of insertion the message that triggered the original callback registering is long gone.</p>
<h4 dir="auto">Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code class="notranslate">doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4 dir="auto">Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4 dir="auto">Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally in local branch based on 5.5.4</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4 dir="auto">Description</h4>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/3279'>https://github.com/kamailio/kamailio/pull/3279</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/3279/commits/492168781edefd15d833a2d4355e461a9ae693fa" class="commit-link">4921687</a> ims_usrloc_pcscf: implementation of db_mode DB_ONLY (value 3)</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/kamailio/kamailio/pull/3279/files">12 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-1d437c3f84a63c7f4b7e223b59841176c6b206dc1f6e55eb2d53fd525f79514b">src/modules/ims_usrloc_pcscf/README</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-eae346813f2ac603232ce7a3c97437c91ee6a326e0e6f8e7f54f5c871726f008">src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c</a>
(22)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-e29df3c1030cb12ab900edf6fa94515ed776a376113cfd1b16452c933c448028">src/modules/ims_usrloc_pcscf/pcontact.c</a>
(85)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-d8a363c81570993b52698e5494ab397e6e5a92004ee36fbee2f154b0843e9f48">src/modules/ims_usrloc_pcscf/udomain.c</a>
(511)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-b89c790105128ec5d4a1d0357d86114b0ba87ca7e2b1ecbd07851868182bf027">src/modules/ims_usrloc_pcscf/udomain.h</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-20015a6e590016768c601f50504b86573ce79a7d74e9efcb0062276e83c2edd8">src/modules/ims_usrloc_pcscf/ul_callback.c</a>
(52)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-55901173a53b2ded257bd09c974f956c6f2be2e3353090d0869c9e2f4ce43406">src/modules/ims_usrloc_pcscf/ul_callback.h</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-703f84065e915eda5f1ed8eb3149ddb1554b0d6b51ec1f05b017753e78399129">src/modules/ims_usrloc_pcscf/ul_rpc.c</a>
(156)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-2c4153ac6512cc0baad0027072970891f7c4cc18dc8fe975b95ed4d42aaba2bf">src/modules/ims_usrloc_pcscf/usrloc.c</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-a1ca23577e21cd965f40f8061af0b8c7ed328e6f67718436ed1dcf12e6533205">src/modules/ims_usrloc_pcscf/usrloc.h</a>
(12)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-679fc41bc11c32b390f4657d229785c93f4ce33003a594c8e219fe54feb6a18f">src/modules/ims_usrloc_pcscf/usrloc_db.c</a>
(50)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/3279/files#diff-069fe50ca85646ab10a2141aca47d5740b05c42508a0c79eebde9f7973584012">src/modules/ims_usrloc_pcscf/usrloc_db.h</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/3279.patch'>https://github.com/kamailio/kamailio/pull/3279.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/3279.diff'>https://github.com/kamailio/kamailio/pull/3279.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/3279">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZJXBLOHMN3I5DXEC4DWHO6UFANCNFSM6AAAAAAR3RTGSI">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/ABO7UZJHCZDPY5UPJPJIPZDWHO6UFA5CNFSM6AAAAAAR3RTGSKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHFL55JAI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><kamailio/kamailio/pull/3279</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/3279",
"url": "https://github.com/kamailio/kamailio/pull/3279",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>