[sr-dev] [kamailio/kamailio] nathelper: fix_nated_sdp added support for a=rtcp param RFC3605 (#2497)

Arsen Semenov notifications at github.com
Mon Oct 5 11:28:46 CEST 2020


- GH #2459


#### Pre-Submission Checklist
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)

#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Checklist:
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [x] Related to issue #2459 

#### Description
fix_nated_sdp() function with flags 0x02 and 0x08 and an IP address as argument (or without one) does modify the media line and the connection line. In addition it will modify IP address in "a=rtcp" parameter (rfc3605) in case if there is one. If a=rtcp param is not found the function doesn't return -1, but prints a DBG message and continues to execute (changing c= or o= lines)  
You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/2497

-- Commit Summary --

  * nathelper: fix_nated_sdp added support for a=rtcp param RFC3605

-- File Changes --

    M src/modules/nathelper/nathelper.c (49)

-- Patch Links --

https://github.com/kamailio/kamailio/pull/2497.patch
https://github.com/kamailio/kamailio/pull/2497.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2497
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20201005/dfdb45f9/attachment-0001.htm>


More information about the sr-dev mailing list