<ul>
<li>GH <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="688041435" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2459" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2459/hovercard" href="https://github.com/kamailio/kamailio/issues/2459">#2459</a></li>
</ul>
<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="688041435" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2459" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2459/hovercard" href="https://github.com/kamailio/kamailio/issues/2459">#2459</a></li>
</ul>
<h4>Description</h4>
<p>fix_nated_sdp() function with flags 0x02 and 0x08 and an IP address as argument (or without one) does modify the media line and the connection line. In addition it will modify IP address in "a=rtcp" parameter (rfc3605) in case if there is one. If a=rtcp param is not found the function doesn't return -1, but prints a DBG message and continues to execute (changing c= or o= lines)</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2497'>https://github.com/kamailio/kamailio/pull/2497</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>nathelper: fix_nated_sdp added support for a=rtcp param RFC3605</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2497/files#diff-6b4f66e9085d3547acd73e9e61be492f">src/modules/nathelper/nathelper.c</a>
    (49)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2497.patch'>https://github.com/kamailio/kamailio/pull/2497.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2497.diff'>https://github.com/kamailio/kamailio/pull/2497.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2497">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOMG55SE4KLLI5PSDTSJGGU5ANCNFSM4SEODPOQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZPYRRE5PVZUFO6LPFTSJGGU5A5CNFSM4SEODPO2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KUZDMVA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2497",
"url": "https://github.com/kamailio/kamailio/pull/2497",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>