[Kamailio-Users] SST module: Min-SE optional in request

[Daniel-Constantin Mierla]

Hello,

I fixed on SVN trunk, could you give a try and report if all ok? I will 
backport then to kamailio 1.4 and openser 1.3 branches.

I did a bit of cleanup, collecting some lines in helper functions to 
avoid duplicates and be coherent in building the headers.

Thank you,
Daniel

On 10/08/08 18:56, Daniel-Constantin Mierla wrote:
> The fixes are easy, the CRLF is missing from the Min-SE header addition 
> -- it is there in openser 1.2 as well -- pretty old :-).
>
> I will commit a bit later in all openser branches.
>
> Cheers,
> Daniel
>
>
> On 10/08/08 18:43, Schumann Sebastian wrote:
>   
>> OK, I added also the other thing to the sourceforge tracker, Bogdan fixed it in OpenSIPS already.
>>
>> Check http://opensips.svn.sourceforge.net/viewvc/opensips/trunk/modules/sst/sst_handlers.c?r1=4775&r2=4777&diff_format=l what you have to change, same applies for kamailio.
>>
>> Sebastian 
>>
>>   
>>     
>>> -----Original Message-----
>>> From: Daniel-Constantin Mierla [mailto:miconda at gmail.com] 
>>> Sent: Wednesday, 08. October 2008 17:41
>>> To: Schumann Sebastian
>>> Cc: users at lists.kamailio.org
>>> Subject: Re: [Kamailio-Users] SST module: Min-SE optional in request
>>>
>>> Hello Sebastian,
>>>
>>> On 10/08/08 15:31, Schumann Sebastian wrote:
>>>     
>>>       
>>>> Dear all
>>>>  
>>>> I might have noticed a bug in SST module:
>>>>  
>>>> If I send an INVITE with
>>>> Session-Expires: 300
>>>> Supported: timer
>>>>  
>>>> I get rejected with 422 Session-Timer too small.
>>>>  
>>>> If a Min-SE: x header with x > set min_se parameter 
>>>>       
>>>>         
>>> included I do not 
>>>     
>>>       
>>>> get the message.
>>>>  
>>>> This is IMHO wrong behavior, as Min-SE is optional in initial 
>>>> INVITE-requests sent by the phone acc. RFC 4028, table 1.
>>>>       
>>>>         
>>> indeed, seems to be an issue. I will look at it.
>>>     
>>>       
>>>>  
>>>> Another thing that I noticed is the response to this 
>>>>       
>>>>         
>>> message includes 
>>>     
>>>       
>>>> the Min-SE header (as it should), but has no linebreak after it (at 
>>>> least in kamailio branch 1.4). The message looks like
>>>> MIN-SE:120Server: Kamailio (1.4.1-notls (i386/linux))
>>>>       
>>>>         
>>> This is clear a bug, perhaps CRLF is forgotten when adding 
>>> header -- seems nobody was using it for long time as was not 
>>> reported so far. I will check to see if the bug is valid for 
>>> openser 1.3.x as well.
>>>
>>> Thanks for reporting.
>>>
>>> Cheers,
>>> Daniel
>>>
>>>     
>>>       
>>>>  
>>>> The phone call cannot be performed.
>>>>  
>>>> At least one thing is IMHO wrong, as the phone cannot complete the 
>>>> call. It might be wrong the call gets rejected, or the 
>>>>       
>>>>         
>>> answer might be 
>>>     
>>>       
>>>> possible like this, but then the phone cannot extract Min-SE due to 
>>>> wrong format.
>>>>  
>>>> Any opinions on this?
>>>>  
>>>> Sebastian
>>>>
>>>>       
>>>>         
>>> ----------------------------------------------------------------------
>>>     
>>>       
>>>> --
>>>>
>>>> _______________________________________________
>>>> Users mailing list
>>>> Users at lists.kamailio.org
>>>> http://lists.kamailio.org/cgi-bin/mailman/listinfo/users
>>>>   
>>>>       
>>>>         
>>> --
>>> Daniel-Constantin Mierla
>>> http://www.asipto.com
>>>
>>>
>>>     
>>>       
>> _______________________________________________
>> Users mailing list
>> Users at lists.kamailio.org
>> http://lists.kamailio.org/cgi-bin/mailman/listinfo/users
>>
>>   
>>     
>
>   

-- 
Daniel-Constantin Mierla
http://www.asipto.com