[SR-Users] tsilo logging

[Federico Cabiddu]

Not a big deal, a pleasure :-)
The small change is on master now.

Cheers,

Federico


On Thu, Oct 13, 2022 at 2:27 PM Alex Balashov <abalashov at evaristesys.com>
wrote:

> Certainly! If you can make that happen due to your greater familiarity
> with the module (as the author), my gratitude would know no bounds. :-)
>
> > On Oct 13, 2022, at 8:10 AM, Federico Cabiddu <
> federico.cabiddu at gmail.com> wrote:
> >
> > Hi Alex,
> > you're right, that's not a pleasant experience.
> > Beside your proposal of having a module function to count the
> transactions (which could be useful), we could set the ts_append log to
> DEBUG and make the function return a specific return code for this case so
> that it can be intercepted in the routing script.
> > Would this be acceptable for you?
> >
> > Federico
> >
> > On Thu, Oct 13, 2022 at 2:00 PM Alex Balashov <abalashov at evaristesys.com>
> wrote:
> > If you’re asking if ts_append() has a documented return value, it does
> not.
> >
> > A function to count transactions stored for a given <domain, RURI> seems
> like a logical need. Then, one could do something like:
> >
> >    if(ts_trans_count(“location”, “$tu”) > 0)
> >       ts_append(“location”, “$tu”);
> >
> > — Alex
> >
> > > On Oct 13, 2022, at 7:56 AM, Olle E. Johansson <oej at edvina.net> wrote:
> > >
> > >
> > >
> > >> On 13 Oct 2022, at 13:50, Alex Balashov <abalashov at evaristesys.com>
> wrote:
> > >>
> > >> Hi,
> > >>
> > >> When there are no stored transactions for an AOR, it logs this error:
> > >>
> > >> Oct 13 07:48:18 gw1 /usr/sbin/kamailio[14758]: ERROR: tsilo
> [ts_append.c:64]: ts_append(): failed to retrieve record for
> sip:abalashov at sip.evaristesys.com
> > >>
> > >> But not having transactions ts_store()’d is a rather normal
> occurrence, right? It is the expected case the vast majority of the time
> that someone registers.
> > >>
> > >> Does that mean one is simply destined to have this scary-looking
> error, to the syslog ERROR facility, for a normal runtime condition? Is
> there not some principle against using attention-grabbing error messages
> this way? Would a patch to fix be welcome?
> > >
> > > I think that’s a bad sysadm experience… Could be a WARNING or a DEBUG.
> > >
> > > Do you get an error code indicating that your silo is empty?
> > >
> > > /O
> > > __________________________________________________________
> > > Kamailio - Users Mailing List - Non Commercial Discussions
> > > sr-users at lists.kamailio.org
> > > Important: keep the mailing list in the recipients, do not reply only
> to the sender!
> > > Edit mailing list options or unsubscribe:
> > > https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
> >
> > --
> > Alex Balashov | Principal | Evariste Systems LLC
> >
> > Tel: +1-706-510-6800 / +1-800-250-5920 (toll-free)
> > Web: http://www.evaristesys.com/, http://www.csrpswitch.com/
> >
> >
> > __________________________________________________________
> > Kamailio - Users Mailing List - Non Commercial Discussions
> > sr-users at lists.kamailio.org
> > Important: keep the mailing list in the recipients, do not reply only to
> the sender!
> > Edit mailing list options or unsubscribe:
> > https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
> > __________________________________________________________
> > Kamailio - Users Mailing List - Non Commercial Discussions
> > sr-users at lists.kamailio.org
> > Important: keep the mailing list in the recipients, do not reply only to
> the sender!
> > Edit mailing list options or unsubscribe:
> > https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
>
> --
> Alex Balashov | Principal | Evariste Systems LLC
>
> Tel: +1-706-510-6800 / +1-800-250-5920 (toll-free)
> Web: http://www.evaristesys.com/, http://www.csrpswitch.com/
>
>
> __________________________________________________________
> Kamailio - Users Mailing List - Non Commercial Discussions
> sr-users at lists.kamailio.org
> Important: keep the mailing list in the recipients, do not reply only to
> the sender!
> Edit mailing list options or unsubscribe:
> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-users/attachments/20221013/394ada2a/attachment.htm>