[SR-Users] Question about textops

[Henning Westerholt]

Hi Mojtaba,

not looked in the code – but it could be related to be able to check with this function for request and replies. Replies will have the method name in their CSEQ.

If you have a requirement that is not available right now in the module, it can be of course extended (e.g. by pull request).

Cheers,

Henning

--
Henning Westerholt – https://skalatan.de/blog/
Kamailio services – https://gilawa.com<https://gilawa.com/>

From: sr-users <sr-users-bounces at lists.kamailio.org> On Behalf Of Mojtaba
Sent: Friday, June 26, 2020 12:43 PM
To: Kamailio (SER) - Users Mailing List <sr-users at lists.kamailio.org>
Subject: Re: [SR-Users] Question about textops

Any idea?
On Wed, 24 Jun 2020, 14:26 Mojtaba, <mespio at gmail.com<mailto:mespio at gmail.com>> wrote:
Hello,
Some confusing things while developing in Kamailio:
In is_method_f function in textops module, the code checks the HDR_CSEQ_F in msg also, and if the method name appears in CSEQ_F, The result is returned TRUE.
These question will  arise why in this function, the CSEQ field in message will check?
if(parse_headers(msg, HDR_CSEQ_F, 0)!=0 || msg->cseq==NULL)

{

LM_ERR("cannot parse cseq header\n");

return -1; /* should it be 0 ?!?! */

}

if(m->s==0)

return (get_cseq(msg)->method_id&m->len)?1:-1;

else

return (get_cseq(msg)->method_id==METHOD_OTHER

&& get_cseq(msg)->method.len==m->len

&& (strncasecmp(get_cseq(msg)->method.s, m->s,
m->len)==0))?1:-1;

I think it would be nice to add new function like: is_cseq_method_f in module to avoid some problem understanding.

--
--Mojtaba Esfandiari.S
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-users/attachments/20200626/5b544f65/attachment.html>