[SR-Users] phonenum module erratic behaviour with 5.1.2

[Daniel-Constantin Mierla]

Hello,

on the flight to Singapore for Fossasia, I got a bit of time to look at
it and the main issue was the documentation, it was no sync'ed with the
code -- the readme listed different attribute names.

In addition, I also found a bug on matching the pv name. Can someone
test with master branch and if all ok, I will backport.

For pv attribute names, see wiki at:

  *
https://www.kamailio.org/wiki/cookbooks/devel/pseudovariables#phn_rid_key_-_phonenum_variables

Cheers,
Daniel


On 21.03.18 13:09, Anthony Joseph Messina wrote:
> George, I do see the same problem, though I haven't had time to investigate 
> yet.  -A
>
> On Monday, March 19, 2018 1:16:17 PM CDT George Diamantopoulos wrote:
>> Hello all,
>>
>> It seems that the phonenum module in at least 5.1.2 (haven't tried previous
>> versions) is behaving somewhat erratically. More specifically, if there are
>> any references to any phn PVs with the key other than "number":
>>
>> if ( phonenum_match("1-484-555-8888", "src") ) {
>> xlog("number norm: $phn(src=>number)\n");
>> xlog("number country: $phn(src=>country)\n");
>> dbg_pv_dump(30, "L_ERR");
>> }
>>
>> kamailio will not start:
>>
>> Mar 19 20:06:49 modcom-sbc-dev1 kamailio[5042]:  0(5044) DEBUG: <core>
>> [core/pvapi.c:494]: pv_spec_lookup(): PV <$phn(src=>country)> is not in
>> cache
>> Mar 19 20:06:49 modcom-sbc-dev1 kamailio[5042]:  0(5044) DEBUG: phonenum
>> [phonenum_pv.c:160]: pv_parse_phonenum_name(): phonenum [src] - key
>> [country]
>> Mar 19 20:06:49 modcom-sbc-dev1 kamailio[5042]:  0(5044) ERROR: phonenum
>> [phonenum_pv.c:205]: pv_parse_phonenum_name(): error at PV phonenum name:
>> src=>country
>> Mar 19 20:06:49 modcom-sbc-dev1 kamailio[5042]:  0(5044) ERROR: <core>
>> [core/pvapi.c:951]: pv_parse_spec2(): pvar "phn" has an invalid name param
>> [src=>country]
>> Mar 19 20:06:49 modcom-sbc-dev1 kamailio[5042]:  0(5044) ERROR: <core>
>> [core/pvapi.c:1106]: pv_parse_spec2(): wrong char [)/41] in
>> [$phn(src=>country)] at [17 (5)]
>> Mar 19 20:06:49 modcom-sbc-dev1 kamailio[5042]:  0(5044) ERROR: xlog
>> [xlog.c:513]: xdbg_fixup_helper(): wrong format[number country:
>> $phn(src=>country)
>>
>> If I comment the offending line, all is well, but when dumping PVs with
>> dbg_pv_dump(30, "L_ERR");, only $phn(src=>number) is listed, not the other
>> keys (country, operator, region according to the docs)
>>
>> However, what is more disturbing is that phn(src=>number) always contains
>> the string provided to phonenum_match() function, even if invalid
>> characters are included, with no normalization. For example:
>>
>> phonenum_match("14~8%^88", "src")
>>
>> will result in dbg_pv_dump reporting:
>>
>> "$phn(src=>number)": "14~8%^88"
>>
>> Please note that I'm using sipwise's debian repository for stretch for
>> kamailio, and debian's stable stretch repository for libphonenumnber
>> (currently at 7.1.0-5+b1). I have also tried building current
>> libphonenumber myself (version v8.9.2), but the result is the same.
>>
>> Is this a bug? Or am I missing something? Thanks!
>>
>> BR,
>> George
>>
>>
>> _______________________________________________
>> Kamailio (SER) - Users Mailing List
>> sr-users at lists.kamailio.org
>> https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - April 16-18, 2018, Berlin - www.asipto.com
Kamailio World Conference - May 14-16, 2018 - www.kamailioworld.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-users/attachments/20180321/78f24476/attachment.html>