[SR-Users] siputils: E164 check is broken

[Daniel-Constantin Mierla]

Hello,

that fix was actually changing:

if (c < '0' && c > '9') return -1;

to:

if (c < '0' || c > '9') return -1;

The rest was auto-indentation by the editor.

Providing the details of like or pasting the code where you refer would
make it easier to understand what do you mean, but I guess you are
referring to the line:

for (i = 1; i <= _user->len; i++) {

Is it?

Cheers,
Daniel

On 12/01/15 15:34, Seudin Kasumovic wrote:
>
> Hi,
>
> The fix below is wrong, condition must be '<' instead of '<='.
>
> https://github.com/kamailio/kamailio/commit/fbcfa198a2c89868fa021f6a63774425e480b27b
>
> and  backported in 4.2
> https://github.com/kamailio/kamailio/commit/2d1032b3c8a1184357615b37da99dfd76526afa7#diff-d7b03e3862e552e90fe6f958ec0f3a12
>
>
> Regards,
> -- 
> Seudin Kasumovic
>
>
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> sr-users at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20150112/ea1056db/attachment.html>