[SR-Users] presence_dialoginfo- first NOTIFY - force_dummy_dialog

Ewgeny evoip at ukr.net
Sat Aug 29 16:20:06 CEST 2015


Hello,

just did a fix in modules/presence_dialoginfo/notify_body.c

  #define DIALOGINFO_EMPTY_BODY "<dialog-info>\
-<dialog id=\"615293b33c62dec073e05d9421e9f48b\" direction=\"recipient\">\
+<dialog id=\"615293b33c62dec073e05d9421e9f48b\" 
call-id=\"830b4fd4-c75d-1233-ca9f-0050569560f4\" direction=\"recipient\">\
  <state>terminated</state>\
  </dialog>\
  </dialog-info>"

and recompile the Kamailio - and  magic happened :) Grandstream lamps 
became GREEN immediately after first SUBSCRIBE.
So now first NOTIFY message with normal XML body including <dialog 
id="830b4fd4-c75d-1233-ca9f-0050569560f4" 
call-id="830b4fd4-c75d-1233-ca9f-0050569560f4" direction="recipient">.

i've found where is DIALOGINFO_EMPTY_BODY defined in the code thanks to 
Daniel, he shown me commit - (commit 
f12f243e39c840b1306bf376c49ef4dab9e7564f).

Thanks a lot Daniel and Luis !!!



Kind Regards
Ewgeny
VoIP engineer

28.08.2015 21:31, Ewgeny пишет:
> i did install 4.3 from rpm - maybe in rpm isn't the latest version ?
> and my configuration with DBTEXT no MySQL used.
>
>
> 28.08.2015 21:26, Luis Azedo пишет:
>> maybe you missed something when you tried 4.3.
>>
>> i do use it and i can confirm that grandstream / bria work well with 
>> this.
>>
>> ------------------------------------------------------------------------
>> *From:* Ewgeny [evoip at ukr.net]
>> *Sent:* Friday, August 28, 2015 11:23 AM
>> *To:* miconda at gmail.com; Kamailio (SER) - Users Mailing List
>> *Cc:* Luis Azedo
>> *Subject:* Re: [SR-Users] presence_dialoginfo- first NOTIFY - 
>> force_dummy_dialog
>>
>> Hello Daniel,
>>
>> No - 'yx' i pasted by mistake :) sorry ....
>> For me without a difference which kamailio version to use - the main 
>> reason to it works as expected.
>> I tried last week latest Kamailio 4.3 from rpm repository - it's also 
>> send first NOTIFY without complete XML body to turn BLF lamp GREEN.
>> So - can you please give a patch to solve that ? No different which 
>> version 4.2 or 4.3.
>>
>> Thanks in advance.
>>
>> Kind Regards
>> Ewgeny
>>
>>
>>
>>
>> 28.08.2015 16:15, Daniel-Constantin Mierla пишет:
>>> Hello,
>>>
>>> first, I see:
>>>
>>> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1" 
>>> ух state="full" entity="sip:9095 at 10.60.1.3">
>>>
>>> Is the 'yx' in the line above appearing or just a result of 
>>> adjusting what you pasted in the email?
>>>
>>> I thought Kazoo in using stock kamailio, in fact Luis (cc-ed) from 
>>> Kazoo pushed a patch to kamailio adding id to dialog tag (commit 
>>> f12f243e39c840b1306bf376c49ef4dab9e7564f), but I don't see the 
>>> call-id there, maybe is added when processing later.
>>>
>>> Checking the source code, the id in dialog tag is only in kamailio 
>>> 4.3, which I guess is what last kazoo is using. Perhaps the patch 
>>> can be backported to branch 4.2, it is not a big change there.
>>>
>>> Cheers,
>>> Daniel
>>>
>>> On 28/08/15 14:54, evoip at ukr.net wrote:
>>>> ||Hello,
>>>> we use Kamailio 4.2 with Presence_DIALOGINFO module for BLF 
>>>> notifications (blinking lamps on phone panel).
>>>>
>>>> Since version 4.1 Kamailio has a new module parametr " 
>>>> modparam("presence_dialoginfo", "force_dummy_dialog", 1)" - this 
>>>> option generate first NOTIFY to Subscribed phone (without PUBLISH 
>>>> message) and it's lamps became GREEN ( <state>terminated</state>).
>>>>
>>>> Without this module parametr the first NOTIFY won't be sent to 
>>>> phone and lamps will stay turned off until first PUBLISH will be 
>>>> handled by presence server.
>>>>
>>>> The first NOTIFY sip message with xml body look like this:
>>>>
>>>>
>>>> NOTIFY sip:1005 at 22.22.22.22:1120 SIP/2.0.
>>>> To: <sip:1005 at 11.11.11.11>;tag=867246696.
>>>> From: <sip:9095 at 11.11.11.11>;tag=495949c4c25d687c77ca707bd10a0818-5171.
>>>> CSeq: 2 NOTIFY.
>>>> Call-ID: 662126467-5060-6 at BJC.BGI.E.CDD.
>>>> Route: <sip:10.60.1.3;r2=on;lr=on>, <sip:11.11.11.11;r2=on;lr=on>.
>>>> Content-Length: 272.
>>>> User-Agent: kamailio (4.2.3 (x86_64/linux)).
>>>> Max-Forwards: 70.
>>>> Event: dialog.
>>>> Subscription-State: active;expires=600.
>>>> Content-Type: application/dialog-info+xml.
>>>> .
>>>> <?xml version="1.0"?>
>>>> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="1" 
>>>> ух state="full" entity="sip:9095 at 10.60.1.3">
>>>>      <dialog  direction="recipient">
>>>>         <state>terminated</state>
>>>>     </dialog>
>>>> </dialog-info>
>>>>
>>>> Especially pay attention on XML body.
>>>>
>>>>
>>>> But for some SIP phones this xml body with state = terminated is 
>>>> not enough to turn the BLF lamp on. (for example Grandstream phones).
>>>> It requires one more or two more fields: "dialog id", "call-id".
>>>>
>>>> <?xml version="1.0"?>
>>>> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" 
>>>> version="28"          state="full" entity="sip:9093 at 10.60.1.3">
>>>>   <dialog id="830b4fd4-c75d-1233-ca9f-0050569560f4" 
>>>> call-id="830b4fd4-c75d-1233-ca9f-0050569560f4" direction="recipient">
>>>>     <state>terminated</state>
>>>>   </dialog>
>>>> </dialog-info>
>>>>
>>>>
>>>>
>>>> The question is how to modify this first NOTIFY XML body message to 
>>>> add "dialog id" and "call-id" to </dialog>.
>>>> For example latest Kamailio Kazoo fixed that already. :)
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> Kind Regards
>>>> Ewgeny
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
>>>> sr-users at lists.sip-router.org
>>>> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users
>>>
>>> -- 
>>> Daniel-Constantin Mierla
>>> http://twitter.com/#!/miconda  -http://www.linkedin.com/in/miconda
>>> Book: SIP Routing With Kamailio -http://www.asipto.com
>>
>
>
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> sr-users at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20150829/ee955b54/attachment.html>


More information about the sr-users mailing list