[SR-Users] Issues with keepalive_timeout

[Daniel-Constantin Mierla]

Hello,

I removed the restriction on nat_bflag (in master and 4.1 branches).

Can anyone test to see if all goes fine even for non-natted contacts?

Cheers,
Daniel

On 20/02/14 01:23, Alex Balashov wrote:
> Okay, so maybe someone who knows the usrloc code better can correct me 
> on this, but I get the impression that the part of the code that ages 
> the contact out if a keepalive reply has not been received is 
> dependent on nat_bflag being set, regardless of the value of the 
> 'ping_nated_only' modparam.
>
> Back to get_all_mem_ucontacts():
>
>                    if ((c->cflags & flags) != flags)
>                         continue;
>
>                    if(ul_keepalive_timeout>0 && c->last_keepalive>0)
>                     {
>                         if((c->cflags & nat_bflag) != 0 && c->sock!=NULL
>                                 && c->sock->proto==PROTO_UDP)
>                         {
> if(c->last_keepalive+ul_keepalive_timeout < tnow)
>                             {
>                                 /* set contact as expired in 10s */
>                                 if(c->expires > tnow + 10)
>                                     c->expires = tnow + 10;
>                                 continue;
>                             }
>                         }
>                     }
>
>

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda