[SR-Users] [sr-dev] Via header, branch parameter and syn_branch

[Richard Brady]

Thanks Henning!

Should anything be done for 3.x? Feels like this is enough of a bug to warrant reverting to branch=0. 

Richard

On 24 May 2013, at 14:54, Henning Westerholt <hw at kamailio.org> wrote:

> Am Donnerstag, 23. Mai 2013, 12:20:00 schrieb Henning Westerholt:
>> [...]
>>> And should the next major release have a default of syn_branch=0?
>>> Since with syn_branch=1 the branch=0 version has been known to cause
>>> interop issues in the past (see below) and I can confirm the
>>> branch=z9hG4bKcydzigwkX version causes interop issues in the present.
>> 
>> Hello Richard,
>> 
>> syn_branch=0 should be made the default, this is what we use as default
>> since years in our backend. The performance concerns that were the reason
>> for introducing it long ago are nowadays not valid anymore (even on
>> embedded systems).
>> 
>> I would suggest to remove this parameter completely, one less if/else case
>> in the module code and also a a parameter less to document and learn for
>> our users.
> 
> Hello Richard,
> 
> the parameter has been removed from the core in git master branch. Now 
> Kamailio should be generate correct Via branch parameter as default. It 
> behaves now as syn_branch = 0 would be set.
> 
> Cheers,
> 
> Henning Westerholt
>