[SR-Users] [PATCH] Memory corruption using s.substr transformation

[Daniel-Constantin Mierla]

Hello,

On 5/2/13 7:55 PM, Martin Mikkelsen wrote:
> On Wed, May 01, 2013 at 11:04:28AM +0200, Alex Hermann wrote:
>> strncpy() must be replaced with memmove() when src and dst (may) overlap.
> You are right, it is probably better to do the copying with memove(), then we
> dont have to fixup all the transformation functions.
>
I don't think this is actually good. Most of operations are safe and 
memcpy is optimized in all cases while memmove can imply more laborious 
operations. Besides that, it is not a single place where to do this change.

Cheers,
Daniel

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda
Kamailio Advanced Training, San Francisco, USA - June 24-27, 2013
   * http://asipto.com/u/katu *