[SR-Users] Fix at IMC module

Daniel-Constantin Mierla miconda at gmail.com
Fri Aug 2 10:45:38 CEST 2013


Hello,

thanks for troubleshooting and fix. I would rather change the define, like:

#define IMC_MEMBER_SKIP     (1<<4)

It should be safer for similar cases in future usages.

I'll look into the code soon.

Cheers,
Daniel

On 8/2/13 10:40 AM, Shankar wrote:
>
> Hello,
>
> While testing group chat via IMC module, we found that owner of a chat 
> room could not destroy the room or invite new users to a chat room 
> after few message exchange.
>
> We had modified the code at "imc_cmd.c" to fix this issue.
>
> Fix,
>
> member->flags &= ~IMC_MEMBER_SKIP; à member->flags &= ~(IMC_MEMBER_SKIP);
>
> where
>
> ~IMC_MEMBER_SKIP is defined as '#define IMC_MEMBER_SKIP     1<<4'.
>
> Here ~ takes precedence over the << operator. With this fix the owner 
> of the chat-room is able to invite new users during a chat and destroy 
> the room.
>
> Regards,
>
> Shankar
>
>
>
> _______________________________________________
> SIP Express Router (SER) and Kamailio (OpenSER) - sr-users mailing list
> sr-users at lists.sip-router.org
> http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla - http://www.asipto.com
http://twitter.com/#!/miconda - http://www.linkedin.com/in/miconda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20130802/6815e1ac/attachment.html>


More information about the sr-users mailing list