[SR-Users] CallControl and MediaProxy

Daniel-Constantin Mierla miconda at gmail.com
Wed Feb 29 00:18:21 CET 2012


That should be. Try changing one of them to (1<<29) and see if all works 
fine.

On another hand, defining and using core msg flags in a module is a 
risk, a different solution has to be done, a simple one is to move the 
definition of these flags in the core, so there will be no overlap in 
the future.

Cheers,
Daniel

On 2/27/12 9:32 PM, Reda Aouad wrote:
> I looked into mediaproxy.c and found the following :
>
> -------------------------------------------------------
> #define FL_USE_MEDIA_PROXY (1<<30)
>
> ...
>
> # dialog callback
>
> __dialog_created (...) {
> ....
>         if ((request->msg_flags & FL_USE_MEDIA_PROXY) == 0)
>                 return;
>          ....
>         use_media_proxy (...);
> }
> -------------------------------------------------------
>
>
> I also found this in call_control.c
> -------------------------------------------------------
> #define FL_USE_CALL_CONTROL       (1<<30)
>
> # Public API
> CallControl (...) {
>         ...
>         msg->msg_flags |= FL_USE_CALL_CONTROL;
>         ...
> }
> -------------------------------------------------------
>
> So I suspect that since the call_control module uses the same flag as 
> the mediaproxy module, call_control function is used, flag 30 is set, 
> and the following condition in the __dialog_created callback function 
> above is never met
>
>         (request->msg_flags & FL_USE_MEDIA_PROXY) == 0
>
> so the callback function continues until executing its last line : 
> use_media_proxy (...)
> which is called on every call to call_control ( ) function..
>
> Reda
>
>
>
> On Mon, Feb 27, 2012 at 18:39, Reda Aouad <reda.aouad at gmail.com 
> <mailto:reda.aouad at gmail.com>> wrote:
>
>     Ok thanks Daniel.
>
>     I'll do what you suggested and we'll see how to proceed.
>
>     Thanks again
>     Reda
>


-- 
Daniel-Constantin Mierla -- http://www.asipto.com
http://linkedin.com/in/miconda -- http://twitter.com/miconda

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sip-router.org/pipermail/sr-users/attachments/20120229/d2233fe9/attachment.htm>


More information about the sr-users mailing list