[SR-Users] dialog module: in-early-dialog requests / race conditions

[Timo Reimann]

Hey Iñaki,

Iñaki Baz Castillo wrote:
> 2010/6/22 Timo Reimann <timo.reimann at 1und1.de>:
>> 1.) The module considers requests routed in early (but not yet
>> confirmed) dialogs to be bogus, as can be seen from a few lines of state
>> machine code in dlg_hash.c:
>>
>> http://git.sip-router.org/cgi-bin/gitweb.cgi?p=sip-router;a=blob;f=modules_k/dialog/dlg_hash.c;h=6aba716c2423cec4402e3be4b55d532d45eabbfa;hb=HEAD#l722
>>
>> In the logs, it shows up something like this:
>>
>> CRITICAL:dialog:log_next_state_dlg: bogus event 8 in state 2 for dlg
>> 0x7f9f237ffff8 [2901:1286709577] with clid '<Call-ID>' and tags '<caller
>> tag>' '<callee tag, always empty>'
>>
>> I believe that such in-early-dialog requests should not trigger
>> bogus-event log messages as they look fine from a standard's point of view.
> 
> Do you mean that an in-dialog request (during early dialog state) is
> considered a "bug" by dialog module? like a PRACK, INFO, OPTIONS,
> MESSAGE or whatever valid in-dialog request in early dialog?

Except for PRACK, all types of in-dialog requests received during early
state are considered "bugs" (see the link to dlg_hash.c I posted above).


> If so, then it's for sure a bug in the code.

Then I will fix it the other day.


Cheers,

--Timo